refactor: remove agent_card_requires_auth config flag#21914
refactor: remove agent_card_requires_auth config flag#21914adamfweidman merged 1 commit intomainfrom
Conversation
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Hi @adamfweidman, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Thank you for linking an issue! This pull request has been automatically reopened. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on removing the deprecated Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully removes the deprecated agent_card_requires_auth configuration flag and its associated logic from the codebase. The changes are consistent across interfaces, Zod schemas, and test cases, aligning with the stated goal of simplifying authentication handling due to native interception of 401/403 responses. The refactor is clean and well-executed.
|
Size Change: -149 B (0%) Total Size: 26.2 MB ℹ️ View Unchanged
|
Summary
Removes the deprecated
agent_card_requires_authflag from the agent configuration, as the system now natively intercepts 401/403s when fetching the Agent Card and retries with the providedA2AAuthConfig.Details
agent_card_requires_authfromBaseAuthConfigandFrontmatterAuthConfig.BaseAuthConfighas been kept as a marker interface (with an eslint override) for all A2A authentication configs.Related Issues
Relates to #17607
How to Validate
npm test -w @google/gemini-cli-core -- src/agents/agentLoader.test.tsnpm run typechecknpm run lintPre-Merge Checklist