Skip to content

refactor: remove agent_card_requires_auth config flag#21914

Merged
adamfweidman merged 1 commit intomainfrom
afw/remove-agent-card-requires-auth
Mar 10, 2026
Merged

refactor: remove agent_card_requires_auth config flag#21914
adamfweidman merged 1 commit intomainfrom
afw/remove-agent-card-requires-auth

Conversation

@adamfweidman
Copy link
Contributor

@adamfweidman adamfweidman commented Mar 10, 2026

Summary

Removes the deprecated agent_card_requires_auth flag from the agent configuration, as the system now natively intercepts 401/403s when fetching the Agent Card and retries with the provided A2AAuthConfig.

Details

  • Removed agent_card_requires_auth from BaseAuthConfig and FrontmatterAuthConfig.
  • BaseAuthConfig has been kept as a marker interface (with an eslint override) for all A2A authentication configs.

Related Issues

Relates to #17607

How to Validate

  1. Run npm test -w @google/gemini-cli-core -- src/agents/agentLoader.test.ts
  2. Run npm run typecheck
  3. Run npm run lint

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@adamfweidman adamfweidman requested a review from a team as a code owner March 10, 2026 18:51
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

Hi @adamfweidman, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Mar 10, 2026
@gemini-cli gemini-cli bot reopened this Mar 10, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 10, 2026

Thank you for linking an issue! This pull request has been automatically reopened.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on removing the deprecated agent_card_requires_auth flag from the agent configuration. This flag is no longer necessary because the system now natively handles authentication for agent cards. The changes include removing the flag from relevant interfaces and updating tests to reflect this change. The removal simplifies the configuration and improves code maintainability.

Highlights

  • Deprecated Flag Removal: The primary goal of this PR is to remove the agent_card_requires_auth configuration flag, which is no longer needed due to native interception of 401/403 errors.
  • Code Cleanup: The changes involve removing the deprecated flag from the BaseAuthConfig and FrontmatterAuthConfig interfaces and related code.
  • Testing: The PR includes updates to tests to reflect the removal of the flag, ensuring continued functionality.
Changelog
  • agentLoader.test.ts
    • Removed test case for the deprecated agent_card_requires_auth flag.
  • agentLoader.ts
    • Removed agent_card_requires_auth from FrontmatterAuthConfig.
    • Removed agent_card_requires_auth from baseAuthFields and related logic.
  • auth-provider/types.ts
    • Removed agent_card_requires_auth from BaseAuthConfig.
Activity
  • The PR removes the deprecated agent_card_requires_auth flag from agent configuration.
  • The system now natively intercepts 401/403 errors when fetching the Agent Card and retries with the provided A2AAuthConfig.
  • The PR includes updates to tests and relevant interfaces to reflect the removal of the flag.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the deprecated agent_card_requires_auth configuration flag and its associated logic from the codebase. The changes are consistent across interfaces, Zod schemas, and test cases, aligning with the stated goal of simplifying authentication handling due to native interception of 401/403 responses. The refactor is clean and well-executed.

@github-actions
Copy link

Size Change: -149 B (0%)

Total Size: 26.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.7 MB -149 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@adamfweidman adamfweidman enabled auto-merge March 10, 2026 18:58
@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Mar 10, 2026
@adamfweidman adamfweidman added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit 00a39b3 Mar 10, 2026
36 of 55 checks passed
@adamfweidman adamfweidman deleted the afw/remove-agent-card-requires-auth branch March 10, 2026 19:31
JaisalJain pushed a commit to JaisalJain/gemini-cli that referenced this pull request Mar 11, 2026
kunal-10-cloud pushed a commit to kunal-10-cloud/gemini-cli that referenced this pull request Mar 12, 2026
liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026
yashodipmore pushed a commit to yashodipmore/geemi-cli that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants