Conversation
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Size Change: +2.22 kB (+0.01%) Total Size: 26.1 MB
ℹ️ View Unchanged
|
gemini-cli
bot
added
the
priority/p1
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the model selection experience by introducing granular control over 'Pro' model access and integrating a new 'Gemini 3.1 Flash Lite' preview model. It ensures that users are presented with appropriate model options based on their access rights and tier, improving clarity and preventing selection of unavailable models. The changes also include an automatic fallback for 'auto' model selection when 'Pro' models are inaccessible, streamlining the user workflow. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to guard Pro model usage based on an experiment flag and adds a new gemini-3.1-flash-lite-preview model for certain users. The changes in the ModelDialog component and its tests correctly handle the new UI logic for filtering models and displaying the new flash lite model based on user tier. The core Config is also updated to switch users without Pro access from an "auto" model to a flash model.
My review found one critical issue in the tests for this new model-switching logic. The test cases have inverted boolean logic for the experiment flag, which means the feature is not being correctly verified. I've provided a code suggestion to fix the tests.
sehoon38
force-pushed
the
feature/free-tier-optimization
branch
from
ccdccf8 to
fa824c0
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to guard pro model usage based on an experiment flag and adds a new flash lite model for certain users. The changes in the Config and ModelDialog components correctly implement this logic. However, I've found a critical issue in the accompanying tests for the Config class, where the test logic is inverted, failing to properly validate the new behavior. Please see the detailed comment.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
/patch |
|
/patch both |
|
🚀 [Step 1/4] Patch workflow(s) waiting for approval! 📋 Details:
⏳ Status: The patch creation workflow has been triggered and is waiting for deployment approval. Please visit the specific workflow links below and approve the runs. 🔗 Track Progress: |
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
# Conflicts: # packages/core/src/config/models.test.ts
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 [Step 3/4] Patch Release Waiting for Approval! 📋 Release Details:
⏳ Status: The patch release has been triggered and is waiting for deployment approval. Please visit the specific workflow run link below and approve the deployment. You'll receive another update when it completes. 🔗 Track Progress: |
|
🚀 [Step 3/4] Patch Release Waiting for Approval! 📋 Release Details:
⏳ Status: The patch release has been triggered and is waiting for deployment approval. Please visit the specific workflow run link below and approve the deployment. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ [Step 4/4] Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
|
✅ [Step 4/4] Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
3 participants
Summary
Guard pro model usage with experiments, and enable 3.1 flash lite for some users.
Details
Related Issues
Related to #21040
How to Validate
Pre-Merge Checklist