Auto detect pnpm global installation path for macOS and Windows

[tisonkun]

Summary

On macOS, the path is $HOME/Library/pnpm/global/5, which doesn't match the current predictions.

Related Issues

This closes #18023.

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the pnpm global installation detection logic within the CLI. It addresses an issue where the current path prediction failed to recognize the standard global installation location for pnpm on macOS, ensuring better compatibility and user experience for macOS users.

Highlights

• Pnpm Global Path Detection: Added a new path pattern to correctly detect pnpm global installations on macOS, specifically $HOME/Library/pnpm/global/5.

Changelog

• packages/cli/src/utils/installationInfo.ts
  • Updated the pnpm global installation path detection logic to include a new pattern relevant to macOS.

Activity

• No review activity or comments have been recorded yet for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to add support for detecting pnpm global installations on macOS. The added check is a bit too broad and could lead to false positives by incorrectly identifying local installations as global ones if the project path contains /pnpm/global. I've suggested a more specific check to prevent this.

[tisonkun]

cc @NTaylorMullen @alisa-alisa

How can we move this forward?

[sejun-run]

I verified the same issue on Windows.

For a global pnpm install on my machine, the resolved path is:

C:/Users/<user>/AppData/Local/pnpm/global/5/...

Since this PR already moved toward explicit platform-specific path checks, I think it would make sense to include the Windows global pnpm layout as well, e.g.:

realPath.includes('/.pnpm/global') ||
realPath.includes('/.local/share/pnpm') ||
realPath.includes('/Library/pnpm/global/') ||
realPath.includes('/AppData/Local/pnpm/global/')

[tisonkun]

I verified the same issue on Windows.

For a global pnpm install on my machine, the resolved path is:

C:/Users/<user>/AppData/Local/pnpm/global/5/...

Since this PR already moved toward explicit platform-specific path checks, I think it would make sense to include the Windows global pnpm layout as well, e.g.:

realPath.includes('/.pnpm/global') ||
realPath.includes('/.local/share/pnpm') ||
realPath.includes('/Library/pnpm/global/') ||
realPath.includes('/AppData/Local/pnpm/global/')

SGTM. Integrated. Now we need some Google friends to move this forward.

@ryanjsalva could you help in review or know who should be in charge here?

[gemini-cli]

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383).

We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'.

This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community!

[tisonkun]

@sejun-run lmao unfortunately Google doesn't seem to like me.

[sejun-run]

@sejun-run lmao unfortunately Google doesn't seem to like me.

T.T don't see why this isnt a big issue for them default update setting is messed up guys..

[cocosheng-g]

@tisonkun, apologies for the bot closing this PR! We have reopened it. Please sync your branch to the latest main and we will have someone review it shortly.

[cocosheng-g]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the getInstallationInfo utility to include additional global installation paths for pnpm on macOS and Windows. A review comment highlights that using includes for path validation can lead to false positives and suggests a more robust approach by anchoring checks to the user's home directory or system-specific environment variables like LOCALAPPDATA.

[gemini-code-assist]

Using includes for path checks is unreliable and can cause false positives (e.g., /other/project/Library/pnpm/global/). It is recommended to anchor these checks to the user's home directory or system folders like LOCALAPPDATA. Additionally, ensure realPath is resolved using a consistent function like resolveToRealPath to comply with repository standards for path validation.

Suggested change

	realPath.includes('/.local/share/pnpm') ||
	realPath.includes('/Library/pnpm/global/') ||
	realPath.includes('/AppData/Local/pnpm/global/')
	(process.platform === 'linux' && realPath.startsWith(require('node:os').homedir().replace(/\\/g, '/') + '/.local/share/pnpm')) ||
	(process.platform === 'darwin' && realPath.startsWith(require('node:os').homedir().replace(/\\/g, '/') + '/Library/pnpm/global/')) ||
	(process.platform === 'win32' && process.env['LOCALAPPDATA'] && realPath.startsWith(process.env['LOCALAPPDATA'].replace(/\\/g, '/') + '/pnpm/global/'))

References

1. Ensure consistent path resolution by using a single, robust function (e.g., resolveToRealPath) for all related path validations, including internal validations in components like WorkspaceContext.

[tisonkun]

@cocosheng-g OK. I'll rebase the PR today.

[tisonkun]

@cocosheng-g I can see you merged the main branch, and I did it again.

Nothing seems to need to change. Gemini's comment indicates a refactor of the section of logic, and I'd prefer to fix the issue first and investigate the refactor later.