Skip to content

feat(browser): add sensitive action controls and read-only noise reduction#22867

Merged
cynthialong0-0 merged 20 commits into
mainfrom
feat/sensitive-browser-actions
Mar 20, 2026
Merged

feat(browser): add sensitive action controls and read-only noise reduction#22867
cynthialong0-0 merged 20 commits into
mainfrom
feat/sensitive-browser-actions

Conversation

@cynthialong0-0
Copy link
Copy Markdown
Contributor

@cynthialong0-0 cynthialong0-0 commented Mar 17, 2026

Summary

This PR implements two tiers of sensitive action controls for the browser agent: hard blocks (always enforced) and
policy-based confirmations (enforced even in YOLO mode). It also adds explicit ALLOW rules for read-only browser
tools to reduce confirmation noise in the default approval mode.

Details

  • New Settings: Added confirmSensitiveActions and blockFileUploads to agents.browser configuration in config.ts and settingsSchema.ts.
  • Hard Block: Implemented a pre-invocation check for upload_file in McpToolInvocation.
  • Policy-based Confirmation: Registered priority 999 ASK_USER rules for upload_file, evaluate_script, fill, and fill_form (when configured) in browserAgentFactory.ts.
  • Added ALLOW rules for readonly tools in browserAgentFactory.ts.
  • Update policy engine to check mcp tools against rule

Related Issues

related #15963 part 2

How to Validate

  1. Enable the browser agent with confirmSensitiveActions on:
  "agents": {
    "overrides": {
      "browser_agent": { "enabled": true }
    },
    "browser": {
      "allowedDomains": ["*.com", "*.edu"],
      "blockFileUploads": true
      "confirmSensitiveActions": true
    }
  }
  1. Bring up the browser agent

Test the upload file behavior by turning blockFileUploads on/off with the following prompt in YOLO mode

Go to the sample file upload form in https://cgi-lib.berkeley.edu/ex/fup.html and upload a readme file

Test other sensitive actions by turning confirmSensitiveActions on/off with prompts like:

Use evaluate_script tool to go to google.com

  1. Verify sensitive tools ask users properly and readonly tools bypass the confirmation check.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Mar 17, 2026

Hi @cynthialong0-0, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2026

Size Change: +3.6 kB (+0.01%)

Total Size: 26.3 MB

Filename Size Change
./bundle/chunk-DKFC5IX2.js 0 B -13.5 MB (removed) 🏆
./bundle/chunk-GCHT4CEF.js 0 B -3.64 MB (removed) 🏆
./bundle/core-42X6JVUH.js 0 B -41.8 kB (removed) 🏆
./bundle/devtoolsService-7BGWANK4.js 0 B -27.7 kB (removed) 🏆
./bundle/interactiveCli-UDWRXC7S.js 0 B -1.61 MB (removed) 🏆
./bundle/oauth2-provider-TPYNICWX.js 0 B -9.19 kB (removed) 🏆
./bundle/chunk-AWF6S5OT.js 13.6 MB +13.6 MB (new file) 🆕
./bundle/chunk-KFWFXZX7.js 3.64 MB +3.64 MB (new file) 🆕
./bundle/core-I6KUXQLP.js 41.8 kB +41.8 kB (new file) 🆕
./bundle/devtoolsService-G3GIVEHR.js 27.7 kB +27.7 kB (new file) 🆕
./bundle/interactiveCli-SAKT5JK5.js 1.61 MB +1.61 MB (new file) 🆕
./bundle/oauth2-provider-OJAQJT3Y.js 9.19 kB +9.19 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-37ZTTFQF.js 966 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-ODOPE5C4.js 1.95 MB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/gemini.js 697 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-O7D6SNBO.js 922 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB
./bundle/undici-4X2YZID5.js 360 B

compressed-size-action

@gemini-cli gemini-cli Bot added priority/p1 Important and should be addressed in the near term. area/security Issues related to security 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. labels Mar 17, 2026
@cynthialong0-0 cynthialong0-0 marked this pull request as ready for review March 18, 2026 19:35
@cynthialong0-0 cynthialong0-0 requested review from a team as code owners March 18, 2026 19:35
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security and user control capabilities of the browser agent by introducing granular controls over sensitive actions. It allows administrators to enforce hard blocks on file uploads and require explicit user confirmation for potentially risky operations, even in 'YOLO' mode. Concurrently, it streamlines the user experience by automatically allowing safe, read-only browser actions, thereby reducing unnecessary prompts and improving workflow efficiency.

Highlights

  • Sensitive Action Controls: Implemented two tiers of sensitive action controls for the browser agent: hard blocks for file uploads and policy-based confirmations for other sensitive actions like evaluate_script, fill, and fill_form.
  • Read-Only Noise Reduction: Added explicit ALLOW rules for read-only browser tools such as take_snapshot, take_screenshot, list_pages, and list_network_requests to reduce confirmation noise in the default approval mode.
  • New Configuration Settings: Introduced confirmSensitiveActions and blockFileUploads settings under agents.browser to control these new behaviors, with corresponding updates to documentation and schema.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively implements two tiers of sensitive action controls for the browser agent: hard blocks and policy-based confirmations, along with noise reduction for read-only browser tools. While the changes introduce important security controls, one high-severity issue was identified that requires attention. A logic flaw in browserAgentFactory.ts causes duplicate policy rules to be registered on every invocation, leading to resource exhaustion and performance degradation.

Comment thread packages/core/src/agents/browser/browserAgentFactory.ts
Copy link
Copy Markdown
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsquared94 gsquared94 added this pull request to the merge queue Mar 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@cynthialong0-0 cynthialong0-0 added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit e8fe43b Mar 20, 2026
27 checks passed
@cynthialong0-0 cynthialong0-0 deleted the feat/sensitive-browser-actions branch March 20, 2026 22:51
ProthamD pushed a commit to ProthamD/gemini-cli that referenced this pull request Mar 29, 2026
warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Issues related to security 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants