chore(lint): enforce zero warnings and cleanup syntax restrictions by alisa-alisa · Pull Request #22902 · google-gemini/gemini-cli

alisa-alisa · 2026-03-18T05:50:30Z

chore(lint): enforce zero warnings and cleanup syntax restrictions

Summary

This PR enforces zero warnings for the project's linting process and refactors ESLint rules to ensure syntax restrictions are consistently applied across the codebase. It also synchronizes lint directives with expanded rule coverage and removes redundant overrides.

Details

Strict Linting: Updated package.json to include --max-warnings 0 in the lint script to ensure a warning-free CI/CD pipeline.
Rule Refactoring: Centralized core syntax restrictions, such as the typeof property access check, into commonRestrictedSyntaxRules. This ensures consistent application across all configuration blocks and prevents accidental rule overwriting in specialized package settings.
Directive Management: Cleaned up linting directives by removing redundant overrides and adding targeted silences where runtime type checks were introduced to improve code robustness.

Related Issues

N/A

How to Validate

Run the project's linting script:
```
npm run lint
```
Verify that it completes successfully with no warnings or errors.

Run relevant tests in @google/gemini-cli and @google/gemini-cli-core to ensure no functional regressions:

npm test -w @google/gemini-cli-core -- src/services/FolderTrustDiscoveryService.ts src/telemetry/sanitize.test.ts src/test-utils/mock-message-bus.ts src/test-utils/mockWorkspaceContext.ts src/tools/read-file.test.ts
npm test -w @google/gemini-cli -- src/nonInteractiveCli.test.ts src/test-utils/customMatchers.ts src/test-utils/mockCommandContext.ts src/test-utils/render.tsx src/test-utils/settings.ts src/ui/IdeIntegrationNudge.test.tsx src/ui/auth/AuthInProgress.test.tsx src/ui/utils/textUtils.test.ts src/utils/cleanup.test.ts src/utils/sessions.test.ts

Pre-Merge Checklist

Updated relevant documentation and README (if needed)
Added/updated tests (if needed)
Noted breaking changes (if any)
Validated on required platforms/methods:
- MacOS
  - npm run

gemini-cli · 2026-03-18T05:50:45Z

Hi @alisa-alisa, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

gemini-code-assist · 2026-03-18T05:50:59Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant project-wide cleanup by systematically removing redundant eslint-disable directives. This initiative aims to streamline the development workflow by eliminating unnecessary noise from pre-commit hooks and enhancing the overall code quality by ensuring that linting rules are consistently applied without being inadvertently bypassed.

Highlights

Codebase Cleanup: Removed numerous unused eslint-disable directives across 17 files to improve code quality and maintainability.
Development Experience Improvement: Stabilized the codebase by preventing pre-commit hooks from automatically stripping redundant eslint-disable comments, which previously caused unintended changes in unrelated PRs.
Linting Enforcement: Ensured that linting rules are now properly enforced in areas where these comments were previously masking potential issues.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request removes a significant number of unused eslint-disable directives across multiple packages. This cleanup is intended to improve code hygiene and prevent unintended modifications by pre-commit hooks. My review of the changes confirms that they are limited to the removal of these now-obsolete linting comments. I have not identified any issues or regressions resulting from this cleanup.

_{Note: Security Review did not run due to the size of the PR.}

github-actions · 2026-03-18T05:54:40Z

Size Change: +138 B (0%)

Total Size: 26.1 MB

Filename	Size	Change
`./bundle/chunk-QGRZDB3C.js`	0 B	-3.64 MB (removed)	🏆
`./bundle/chunk-Y4WT6QYH.js`	0 B	-14.5 MB (removed)	🏆
`./bundle/core-LCHJY526.js`	0 B	-42.4 kB (removed)	🏆
`./bundle/devtoolsService-OSKK3Q7G.js`	0 B	-27.7 kB (removed)	🏆
`./bundle/interactiveCli-DWPVPNMG.js`	0 B	-1.61 MB (removed)	🏆
`./bundle/oauth2-provider-QW3CAXQO.js`	0 B	-9.16 kB (removed)	🏆
`./bundle/chunk-AV22IDIQ.js`	3.64 MB	+3.64 MB (new file)	🆕
`./bundle/chunk-WAFU4T7N.js`	14.5 MB	+14.5 MB (new file)	🆕
`./bundle/core-3RNTAJHH.js`	42.4 kB	+42.4 kB (new file)	🆕
`./bundle/devtoolsService-GGY4XTWS.js`	27.7 kB	+27.7 kB (new file)	🆕
`./bundle/interactiveCli-N4YCSWN7.js`	1.61 MB	+1.61 MB (new file)	🆕
`./bundle/oauth2-provider-S7FX3Q4D.js`	9.16 kB	+9.16 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size
`./bundle/chunk-34MYV7JD.js`	2.45 kB
`./bundle/chunk-5725SFQR.js`	1.95 MB
`./bundle/chunk-5AUYMPVF.js`	858 B
`./bundle/chunk-664ZODQF.js`	124 kB
`./bundle/chunk-DAHVX5MI.js`	206 kB
`./bundle/chunk-IUUIT4SU.js`	56.5 kB
`./bundle/chunk-RJTRUG2J.js`	39.8 kB
`./bundle/devtools-36NN55EP.js`	696 kB
`./bundle/dist-T73EYRDX.js`	356 B
`./bundle/gemini.js`	519 kB
`./bundle/getMachineId-bsd-TXG52NKR.js`	1.55 kB
`./bundle/getMachineId-darwin-7OE4DDZ6.js`	1.55 kB
`./bundle/getMachineId-linux-SHIFKOOX.js`	1.34 kB
`./bundle/getMachineId-unsupported-5U5DOEYY.js`	1.06 kB
`./bundle/getMachineId-win-6KLLGOI4.js`	1.72 kB
`./bundle/memoryDiscovery-OV4FUTHJ.js`	922 B
`./bundle/multipart-parser-KPBZEGQU.js`	11.7 kB
`./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js`	221 kB
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js`	227 kB
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js`	11.5 kB
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js`	132 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB
`./bundle/sandbox-macos-strict-open.sb`	4.82 kB
`./bundle/sandbox-macos-strict-proxied.sb`	5.02 kB
`./bundle/src-QVCVGIUX.js`	47 kB
`./bundle/tree-sitter-7U6MW5PS.js`	274 kB
`./bundle/tree-sitter-bash-34ZGLXVX.js`	1.84 MB

_{compressed-size-action}

gundermanc · 2026-03-18T05:59:12Z

packages/a2a-server/src/agent/task.ts

    if (
      part.kind !== 'data' ||
      !part.data ||
-      // eslint-disable-next-line no-restricted-syntax


I just added a linter rule a few days back that should be flagging these. Is there something that is causing it to not work anymore?

Here's the PR for context: #21485

gundermanc

Instead of deleting these, can we fix the linter rule so it's correctly flagging these issues?

swissspidy · 2026-03-18T09:01:01Z

eslint-comments/no-unused-disable can be used to flag unused directives like these.

eslint.config.js

packages/cli/src/ui/auth/AuthInProgress.test.tsx

package.json

gundermanc · 2026-03-18T19:18:10Z

eslint-comments/no-unused-disable can be used to flag unused directives like these.

Thanks for the recommendation, we have an issue filed for this, but we need to 'get to green' first: #22948

alisa-alisa marked this pull request as ready for review March 18, 2026 05:50

alisa-alisa requested review from a team as code owners March 18, 2026 05:50

gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Mar 18, 2026

gemini-code-assist bot reviewed Mar 18, 2026

View reviewed changes

alisa-alisa force-pushed the alisa/cleanup-lint-directives branch from c1939bc to 2b854fe Compare March 18, 2026 05:54

gundermanc reviewed Mar 18, 2026

View reviewed changes

gundermanc requested changes Mar 18, 2026

View reviewed changes

Fixing linter

66f91e4

alisa-alisa force-pushed the alisa/cleanup-lint-directives branch from 2b854fe to 66f91e4 Compare March 18, 2026 18:47

alisa-alisa requested a review from a team as a code owner March 18, 2026 18:47

Merge branch 'main' into alisa/cleanup-lint-directives

609a5c0

alisa-alisa changed the title ~~chore: remove unused eslint-disable directives~~ chore(lint): enforce zero warnings and cleanup syntax restrictions Mar 18, 2026

gundermanc reviewed Mar 18, 2026

View reviewed changes

eslint.config.js Show resolved Hide resolved

gundermanc reviewed Mar 18, 2026

View reviewed changes

packages/cli/src/ui/auth/AuthInProgress.test.tsx Show resolved Hide resolved

gundermanc reviewed Mar 18, 2026

View reviewed changes

package.json Show resolved Hide resolved

gundermanc approved these changes Mar 18, 2026

View reviewed changes

alisa-alisa enabled auto-merge March 18, 2026 19:21

gundermanc mentioned this pull request Mar 20, 2026

chore(lint): cleanup unused eslint-disable directives #23212

Open

18 tasks

Merge branch 'main' into alisa/cleanup-lint-directives

983adbc

galz10 approved these changes Mar 20, 2026

View reviewed changes

alisa-alisa added 2 commits March 20, 2026 16:17

Merge branch 'main' into alisa/cleanup-lint-directives

a124244

Merge branch 'main' into alisa/cleanup-lint-directives

12945f1

alisa-alisa added this pull request to the merge queue Mar 21, 2026

Merged via the queue into main with commit 1a70fdd Mar 21, 2026
27 checks passed

alisa-alisa deleted the alisa/cleanup-lint-directives branch March 21, 2026 04:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(lint): enforce zero warnings and cleanup syntax restrictions#22902

chore(lint): enforce zero warnings and cleanup syntax restrictions#22902
alisa-alisa merged 5 commits intomainfrom
alisa/cleanup-lint-directives

alisa-alisa commented Mar 18, 2026 •

edited

Loading

Uh oh!

gemini-cli bot commented Mar 18, 2026

Uh oh!

gemini-code-assist bot commented Mar 18, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

github-actions bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

gundermanc Mar 18, 2026

Uh oh!

gundermanc left a comment

Uh oh!

swissspidy commented Mar 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gundermanc commented Mar 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alisa-alisa commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

chore(lint): enforce zero warnings and cleanup syntax restrictions

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

gemini-cli bot commented Mar 18, 2026

Uh oh!

gemini-code-assist bot commented Mar 18, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gundermanc Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

gundermanc left a comment

Choose a reason for hiding this comment

Uh oh!

swissspidy commented Mar 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gundermanc commented Mar 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alisa-alisa commented Mar 18, 2026 •

edited

Loading

github-actions bot commented Mar 18, 2026 •

edited

Loading