fix: "allow always" for commands with paths#23558
Conversation
|
Size Change: -110 B (0%) Total Size: 26.1 MB
ℹ️ View Unchanged
|
scidomino
changed the title
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where shell command approval policies were not correctly storing the full path of commands. By modifying the command normalization logic, the system now preserves complete command paths, enhancing the accuracy of 'allow always' policies and providing users with a clearer understanding of the commands they are approving in the UI. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the shell-utils module. The normalizeCommandName function in packages/core/src/utils/shell-utils.ts has been simplified to only trim the input string, removing the logic that previously extracted just the binary name from a path. Correspondingly, the test case in packages/core/src/utils/shell-utils.test.ts for getCommandRoots has been updated to reflect this change, now expecting the full path of a command rather than just its binary name when a path is provided. There is no feedback to provide.
gemini-cli
bot
added
priority/p0
|
/patch preview |
|
🚀 [Step 1/4] Patch workflow(s) waiting for approval! 📋 Details:
⏳ Status: The patch creation workflow has been triggered and is waiting for deployment approval. Please visit the specific workflow links below and approve the runs. 🔗 Track Progress: |
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 [Step 3/4] Patch Release Waiting for Approval! 📋 Release Details:
⏳ Status: The patch release has been triggered and is waiting for deployment approval. Please visit the specific workflow run link below and approve the deployment. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ [Step 4/4] Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
3 participants
Summary
Don't strip paths from long commands when writing allow policies.
Details
This also changes it to display the full name of the command in the UI. This is probably better since users should understand what command they are approving.
Previously this would have read
Allow execution of: 'command'?Related Issues
For #16450
How to Validate
long/path/to/commandwith the shell tool.auto-saved.tomlincludes the full path.Pre-Merge Checklist