fix(patch): cherry-pick b2d6dc4 to release/v0.35.0-preview.4-pr-23546 [CONFLICTS]#23585
Conversation
# Conflicts: # integration-tests/browser-policy.test.ts # packages/a2a-server/src/config/config.test.ts # packages/a2a-server/src/config/config.ts
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick that primarily updates the default setting for experimental agents to be disabled. This change is propagated across documentation, configuration schemas, and core logic. Additionally, new integration tests have been introduced to ensure the correct functioning of browser agent policies. The PR currently requires manual conflict resolution to proceed. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to disable agents by default by changing the experimental.enableAgents setting to false. The changes are applied consistently across documentation, schemas, tests, and configuration logic. However, the cherry-pick process has introduced merge conflicts in two files, which are critical issues that must be resolved. My review focuses on these conflicts.
Note: Security Review did not run due to the size of the PR.
|
Size Change: +575 B (0%) Total Size: 26.2 MB
ℹ️ View Unchanged
|
e88b56b
into
release/v0.35.0-preview.4-pr-23546
This PR automatically cherry-picks commit b2d6dc4 to patch version v0.35.0-preview.4 in the preview release to create version 0.35.0-preview.5.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: