Skip to content

feat(cli): minimalist sandbox status labels#24582

Merged
galz10 merged 2 commits intomainfrom
galzahavi/fix/sandbox-messaging
Apr 3, 2026
Merged

feat(cli): minimalist sandbox status labels#24582
galz10 merged 2 commits intomainfrom
galzahavi/fix/sandbox-messaging

Conversation

@galz10
Copy link
Copy Markdown
Collaborator

@galz10 galz10 commented Apr 2, 2026

Summary

This PR updates the CLI footer to provide a minimalist sandbox status. It groups all agent-level sandboxing (Docker, Podman, macOS Seatbelt) under a single "current process" label and changes the tool-level sandboxing status to "all tools".

Details

  • Updated SandboxIndicator in Footer.tsx to use:
    • "current process" (Yellow) for all agent-level sandboxing (detected via SANDBOX env).
    • "all tools" (Yellow) for tool-level sandboxing (detected via config).
    • "no sandbox" (Red) for unsandboxed state.
  • Aligned all sandboxed states to use yellow (theme.status.warning) for consistent visual feedback.
  • Updated Footer.test.tsx and added unit tests for the new labeling.
  • Fixed an ESLint spread operator error on class instances in tests.

Related Issues

How to Validate

  1. Run the CLI with security.toolSandboxing enabled in settings.
  2. Observe "all tools" in yellow in the footer.
  3. Run the CLI in Docker/Podman or with sandbox-exec and observe "current process" in yellow.
  4. Run npm test -w @google/gemini-cli -- src/ui/components/Footer.test.tsx.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the CLI footer's sandbox status display to provide a more minimalist and consistent user experience. By grouping various agent-level sandboxing methods under a single label and standardizing the color scheme, the UI now provides clearer feedback regarding the current security context of the application.

Highlights

  • Simplified Sandbox Status Labels: Replaced specific environment-based sandbox labels with unified 'current process' and 'all tools' indicators in the CLI footer.
  • Consistent Visual Feedback: Updated all sandboxed states to use the warning color (yellow) for improved UI consistency.
  • Test Suite Updates: Updated existing tests to reflect new labeling and added new unit tests to cover the 'all tools' sandbox state.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli gemini-cli bot added area/core Issues related to User Interface, OS Support, Core Functionality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. labels Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Size Change: -259 B (0%)

Total Size: 34.7 MB

Filename Size Change
./bundle/chunk-E6FD6MZH.js 0 B -3.82 MB (removed) 🏆
./bundle/chunk-HR7JL2FP.js 0 B -14.8 MB (removed) 🏆
./bundle/core-JR5RZRDT.js 0 B -45.1 kB (removed) 🏆
./bundle/devtoolsService-4E5O5ABK.js 0 B -28.4 kB (removed) 🏆
./bundle/interactiveCli-24GII3FW.js 0 B -1.66 MB (removed) 🏆
./bundle/oauth2-provider-ULBBA3YS.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-ESAAFPQC.js 14.8 MB +14.8 MB (new file) 🆕
./bundle/chunk-VN7WV6X4.js 3.82 MB +3.82 MB (new file) 🆕
./bundle/core-VW4ZZLCW.js 45.1 kB +45.1 kB (new file) 🆕
./bundle/devtoolsService-KJ7POAXV.js 28.4 kB +28.4 kB (new file) 🆕
./bundle/interactiveCli-FCJSIT5J.js 1.66 MB +1.66 MB (new file) 🆕
./bundle/oauth2-provider-RZBHVTKO.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/bundled/third_party/index.js 8 MB
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-CEPJKI2L.js 1.96 MB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/chunk-U4FACSVX.js 1.13 kB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/events-CLX3JQHP.js 418 B
./bundle/gemini.js 550 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-QMN7XULO.js 980 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the sandbox indicator in the CLI footer by replacing specific environment details with more generic labels. When the SANDBOX environment variable is set, the UI now displays "current process" instead of the specific sandbox name or macOS Seatbelt info. Additionally, it introduces an "all tools" status when sandboxing is enabled through the configuration. The associated tests have been updated to reflect these string changes and include a new test case for the enabled sandbox configuration. I have no feedback to provide.

@galz10 galz10 requested a review from a team as a code owner April 3, 2026 00:25
@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Apr 3, 2026
@galz10 galz10 added this pull request to the merge queue Apr 3, 2026
Merged via the queue into main with commit e54eecc Apr 3, 2026
27 checks passed
@galz10 galz10 deleted the galzahavi/fix/sandbox-messaging branch April 3, 2026 05:55
afanty2021 pushed a commit to afanty2021/gemini-cli that referenced this pull request Apr 4, 2026
warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026
HaleTom pushed a commit to HaleTom/gemini-cli that referenced this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants