feat(cli): minimalist sandbox status labels#24582
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the CLI footer's sandbox status display to provide a more minimalist and consistent user experience. By grouping various agent-level sandboxing methods under a single label and standardizing the color scheme, the UI now provides clearer feedback regarding the current security context of the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: -259 B (0%) Total Size: 34.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request simplifies the sandbox indicator in the CLI footer by replacing specific environment details with more generic labels. When the SANDBOX environment variable is set, the UI now displays "current process" instead of the specific sandbox name or macOS Seatbelt info. Additionally, it introduces an "all tools" status when sandboxing is enabled through the configuration. The associated tests have been updated to reflect these string changes and include a new test case for the enabled sandbox configuration. I have no feedback to provide.
Summary
This PR updates the CLI footer to provide a minimalist sandbox status. It groups all agent-level sandboxing (Docker, Podman, macOS Seatbelt) under a single "current process" label and changes the tool-level sandboxing status to "all tools".
Details
SandboxIndicatorinFooter.tsxto use:"current process"(Yellow) for all agent-level sandboxing (detected viaSANDBOXenv)."all tools"(Yellow) for tool-level sandboxing (detected via config)."no sandbox"(Red) for unsandboxed state.theme.status.warning) for consistent visual feedback.Footer.test.tsxand added unit tests for the new labeling.Related Issues
How to Validate
security.toolSandboxingenabled in settings.sandbox-execand observe "current process" in yellow.npm test -w @google/gemini-cli -- src/ui/components/Footer.test.tsx.Pre-Merge Checklist