fix(cli): prevent restart loop on initial IDE trust mismatch#25163
fix(cli): prevent restart loop on initial IDE trust mismatch#25163achaljhawar wants to merge 4 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the Gemini CLI would enter an infinite restart loop due to trust status mismatches between the IDE and local settings during startup. By introducing a connection state check and optimizing event emission in the IdeClient, the CLI now correctly handles initial trust states while maintaining expected behavior for subsequent changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prevents an infinite restart loop that occurred when the local and IDE trust statuses differed upon startup. It introduces a hasEverBeenConnected flag in useIdeTrustListener to ensure restarts only trigger after an initial connection is established. Additionally, IdeClient now tracks the lastNotifiedTrustValue to avoid redundant trust change notifications. A new test case was added to verify this behavior. I have no feedback to provide.
Summary
When opening a workspace that is trusted in the IDE but untrusted in the local Gemini CLI settings (or vice versa), the CLI would get stuck in an infinite restart loop prompting the user that trust has changed.
This fix introduces a check to ignore the initial trust mismatch upon the first connection, while still preserving the restart behavior for subsequent trust changes during an active session. It also optimizes
IdeClientto only emit trust events whenthe value actually changes.
Related Issues
Fixes #25032
Pre-Merge Checklist