Skip to content

fix(cli): prevent restart loop on initial IDE trust mismatch#25163

Open
achaljhawar wants to merge 4 commits intogoogle-gemini:mainfrom
achaljhawar:fix/ide-trust-mismatch-restart-loop-25032
Open

fix(cli): prevent restart loop on initial IDE trust mismatch#25163
achaljhawar wants to merge 4 commits intogoogle-gemini:mainfrom
achaljhawar:fix/ide-trust-mismatch-restart-loop-25032

Conversation

@achaljhawar
Copy link
Copy Markdown
Contributor

Summary

When opening a workspace that is trusted in the IDE but untrusted in the local Gemini CLI settings (or vice versa), the CLI would get stuck in an infinite restart loop prompting the user that trust has changed.

This fix introduces a check to ignore the initial trust mismatch upon the first connection, while still preserving the restart behavior for subsequent trust changes during an active session. It also optimizes IdeClient to only emit trust events when
the value actually changes.

Related Issues

Fixes #25032

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@achaljhawar achaljhawar requested a review from a team as a code owner April 11, 2026 04:06
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the Gemini CLI would enter an infinite restart loop due to trust status mismatches between the IDE and local settings during startup. By introducing a connection state check and optimizing event emission in the IdeClient, the CLI now correctly handles initial trust states while maintaining expected behavior for subsequent changes.

Highlights

  • Restart Loop Prevention: Implemented a check in the IDE trust listener to ignore initial trust mismatches upon the first connection, preventing unnecessary restart loops.
  • Event Optimization: Updated IdeClient to track the last notified trust value and only emit trust change events when the value actually changes.
  • Testing: Added a new test case to verify that trust mismatches during initial connection do not trigger a restart.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prevents an infinite restart loop that occurred when the local and IDE trust statuses differed upon startup. It introduces a hasEverBeenConnected flag in useIdeTrustListener to ensure restarts only trigger after an initial connection is established. Additionally, IdeClient now tracks the lastNotifiedTrustValue to avoid redundant trust change notifications. A new test case was added to verify this behavior. I have no feedback to provide.

@gemini-cli gemini-cli bot added priority/p1 Important and should be addressed in the near term. area/core Issues related to User Interface, OS Support, Core Functionality labels Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When folder is trusted by VSCode but untrusted in trustedFolders.json, Gemini CLI is stuck in restart loop

1 participant