Skip to content

Add skip_github_release option to Manual Release.#8932

Merged
mattKorwel merged 1 commit intomainfrom
tomm_workflow
Sep 19, 2025
Merged

Add skip_github_release option to Manual Release.#8932
mattKorwel merged 1 commit intomainfrom
tomm_workflow

Conversation

@scidomino
Copy link
Copy Markdown
Collaborator

TLDR

Adds an option to skip creating a github release.

Dive Deeper

For manual test releases we probably don't want to do a github release.

Reviewer Test Plan

I tested this manually.

@scidomino scidomino requested review from a team as code owners September 19, 2025 18:30
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the publish-release GitHub Action by adding a new configuration option to bypass the creation of a GitHub release. This provides increased flexibility for release workflows, especially for scenarios like manual test releases where a formal GitHub release might not be necessary or desired.

Highlights

  • New Input Added: Introduced a new boolean input named skip_github_release to the publish-release GitHub Action, allowing users to explicitly control whether a GitHub release is created. This input defaults to false.
  • Conditional Release Creation: Modified the 'Create GitHub Release' step within the action to incorporate the new skip_github_release input. The release will now only be created if dry-run is false AND skip_github_release is also false.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a skip_github_release option to the publish-release action, allowing the GitHub release creation step to be skipped. The implementation is straightforward, but I have a couple of suggestions to improve consistency and correctness in the action's YAML definition. Specifically, I recommend aligning the new input's name with the existing kebab-case convention and using direct boolean evaluation in the conditional logic for if statements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 19, 2025

Size Change: -2 B (0%)

Total Size: 17.3 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.3 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@scidomino scidomino changed the title Add skip_github_release option. Add skip_github_release option to Manual Release. Sep 19, 2025
Copy link
Copy Markdown
Member

@richieforeman richieforeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG (pending comments)

Copy link
Copy Markdown
Collaborator

@mattKorwel mattKorwel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, we should also have a no channel option. if i'm pushing v0.0.11111 it really doesn't need the dev channel tag. doesn't have to block here though.

@mattKorwel mattKorwel added this pull request to the merge queue Sep 19, 2025
Merged via the queue into main with commit b9f6283 Sep 19, 2025
19 checks passed
@mattKorwel mattKorwel deleted the tomm_workflow branch September 19, 2025 19:17
nagendrareddy10 pushed a commit to nagendrareddy10/gemini-cli that referenced this pull request Sep 22, 2025
yashv6655 added a commit to yashv6655/gemini-cli that referenced this pull request Sep 22, 2025
giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants