Add skip_github_release option to Manual Release.#8932
Conversation
Summary of ChangesHello @scidomino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a skip_github_release option to the publish-release action, allowing the GitHub release creation step to be skipped. The implementation is straightforward, but I have a couple of suggestions to improve consistency and correctness in the action's YAML definition. Specifically, I recommend aligning the new input's name with the existing kebab-case convention and using direct boolean evaluation in the conditional logic for if statements.
|
Size Change: -2 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
5e13065 to
7de9f3b
Compare
mattKorwel
left a comment
There was a problem hiding this comment.
Honestly, we should also have a no channel option. if i'm pushing v0.0.11111 it really doesn't need the dev channel tag. doesn't have to block here though.
TLDR
Adds an option to skip creating a github release.
Dive Deeper
For manual test releases we probably don't want to do a github release.
Reviewer Test Plan
I tested this manually.