[r2.14.0, rtsp library] setting repeat mode causes fatal error, resulting in force close

[warren-bank]

logcat errors:

  05-29 12:15:00.692 26748-26882/com.github.warren_bank.exoplayer_airplay_receiver E/AndroidRuntime: FATAL EXCEPTION: ExoPlayer:Playback
      Process: com.github.warren_bank.exoplayer_airplay_receiver, PID: 26748
      java.lang.NullPointerException
          at com.google.android.exoplayer2.util.Assertions.checkNotNull(Assertions.java:154)
          at com.google.android.exoplayer2.source.rtsp.RtpDataLoadable.setTimestamp(RtpDataLoadable.java:111)
          at com.google.android.exoplayer2.source.rtsp.RtspMediaPeriod$InternalListener.onPlaybackStarted(RtspMediaPeriod.java:495)
          at com.google.android.exoplayer2.source.rtsp.RtspClient$MessageListener.onPlayResponseReceived(RtspClient.java:496)
          at com.google.android.exoplayer2.source.rtsp.RtspClient$MessageListener.onRtspMessageReceived(RtspClient.java:412)
          at com.google.android.exoplayer2.source.rtsp.RtspMessageChannel$Receiver.lambda$handleRtspMessage$0(RtspMessageChannel.java:291)
          at com.google.android.exoplayer2.source.rtsp.-$$Lambda$RtspMessageChannel$Receiver$frEfu1WfqENR1_7bFfrua9iV9BY.run(lambda)
          at android.os.Handler.handleCallback(Handler.java:733)
          at android.os.Handler.dispatchMessage(Handler.java:95)
          at android.os.Looper.loop(Looper.java:136)
          at android.os.HandlerThread.run(HandlerThread.java:61)
  05-29 12:15:03.062 26748-26748/com.github.warren_bank.exoplayer_airplay_receiver E/EventLogger: playerFailed [eventTime=219.65, mediaPos=0.00, window=0, period=0
        com.google.android.exoplayer2.ExoPlaybackException: null error, index=-1, format=null, format_supported=YES
          at com.google.android.exoplayer2.SimpleExoPlayer.setVideoOutputInternal(SimpleExoPlayer.java:1922)
          at com.google.android.exoplayer2.SimpleExoPlayer.access$4000(SimpleExoPlayer.java:92)
          at com.google.android.exoplayer2.SimpleExoPlayer$ComponentListener.surfaceDestroyed(SimpleExoPlayer.java:2278)
          at android.view.SurfaceView.updateWindow(SurfaceView.java:556)
          at android.view.SurfaceView.access$000(SurfaceView.java:86)
          at android.view.SurfaceView$1.handleMessage(SurfaceView.java:129)
          at android.os.Handler.dispatchMessage(Handler.java:102)
          at android.os.Looper.loop(Looper.java:136)
          at android.app.ActivityThread.main(ActivityThread.java:5118)
          at java.lang.reflect.Method.invokeNative(Native Method)
          at java.lang.reflect.Method.invoke(Method.java:515)
          at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:790)
          at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:606)
          at dalvik.system.NativeStart.main(Native Method)
       Caused by: com.google.android.exoplayer2.ExoTimeoutException: Detaching surface timed out.
          at com.google.android.exoplayer2.SimpleExoPlayer.setVideoOutputInternal(SimpleExoPlayer.java:1920)
          at com.google.android.exoplayer2.SimpleExoPlayer.access$4000(SimpleExoPlayer.java:92) 
          at com.google.android.exoplayer2.SimpleExoPlayer$ComponentListener.surfaceDestroyed(SimpleExoPlayer.java:2278) 
          at android.view.SurfaceView.updateWindow(SurfaceView.java:556) 
          at android.view.SurfaceView.access$000(SurfaceView.java:86) 
          at android.view.SurfaceView$1.handleMessage(SurfaceView.java:129) 
          at android.os.Handler.dispatchMessage(Handler.java:102) 
          at android.os.Looper.loop(Looper.java:136) 
          at android.app.ActivityThread.main(ActivityThread.java:5118) 
          at java.lang.reflect.Method.invokeNative(Native Method) 
          at java.lang.reflect.Method.invoke(Method.java:515) 
          at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:790) 
          at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:606) 
          at dalvik.system.NativeStart.main(Native Method) 
      ]

---

quick trace through code to find cause:

• method: RtpDataLoadable.setTimestamp

    public void setTimestamp(long timestamp) {
      if (!checkNotNull(extractor).hasReadFirstRtpPacket()) {...}
    }

• method: RtpDataLoadable.load

    public void load() {
      extractor = new RtpExtractor(rtspMediaTrack.payloadFormat, trackId);
    }

• inner class constructor: RtspMediaPeriod.RtpLoadInfo

    public RtpLoadInfo(...){
      this.loadable = new RtpDataLoadable(...);
    }

• method: RtspMediaPeriod.getLoadableByTrackUri

    private RtpDataLoadable getLoadableByTrackUri(Uri trackUri) {
      RtpLoadInfo loadInfo = rtspLoaderWrappers.get(i).loadInfo;
      return loadInfo.loadable;
    }

• method: RtspMediaPeriod.onPlaybackStarted

    public void onPlaybackStarted(...) {
      RtpDataLoadable dataLoadable = getLoadableByTrackUri(trackTiming.uri);
  
      // NEVER CALLS: dataLoadable.load();
  
      dataLoadable.setTimestamp(trackTiming.rtpTimestamp);
      // ERROR: dataLoadable.extractor is NULL
    }

[claincly]

Hello there, can you also post the RTSP messages? You can print the messages by following this simple step
#3854 (comment)

[warren-bank]

I must be slow.. that doesn't look simple to me ☹️

Here is where the RtspMediaSource is initialized. The following code removes all of the app's complexity and summarizes how it is used:

  String uri = "rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_175k.mov";
  String mimeType = "application/x-rtsp";
  MediaItem mediaItem = new MediaItem.Builder().setUri(uri).setMimeType(mimeType).build();
  MediaSource mediaSource = (MediaSource) new RtspMediaSource.Factory().createMediaSource(mediaItem);

  ConcatenatingMediaSource concatenatingMediaSource = new ConcatenatingMediaSource();
  MediaSource[] mediaSources = new MediaSource[]{mediaSource};
  concatenatingMediaSource.addMediaSources(
    Arrays.asList(mediaSources)
  );

  SimpleExoPlayer player = new SimpleExoPlayer.Builder(context).build();
  player.prepare(concatenatingMediaSource);

Is there a way to hook the AnalyticsCollector (ie: configure an AnalyticsListener) to the RTSP library.. so it can provide a deep log into all RTSP-related events? I'm currently using the stock EventLogger.

[warren-bank]

  - needs triage
  + need more info

• I made a minimal barebones app to run the code in the previous comment, and (to my surprise) it works correctly
  • code
  • apk
• so I need to temporarily put a pin in this issue
  • run the app that's experiencing a problem through the debugger
  • try to figure out why it crashes (but only when loading an RTSP url)

[claincly]

Sorry I meant the instructions to add the logs to see the actual exchanged RTSP messages.

To start, could you try plugging your link to any of RTSP links in
https://github.com/google/ExoPlayer/blob/d5d78238773d6dc53b54849ca10d845a4421284c/demos/main/src/main/assets/media.exolist.json
(just change any one uri, to "rtsp://..."), build the demo app, and see if it plays?

I can verify the link rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_175k.mov works in the demo app, let me see what else is wrong.

[warren-bank]

Well..

• the barebones app (above) proves that the RTSP library works..
• the weird thing is.. I'm walking through my app with the debugger and everything looks good.. but
  • the PlayerView is black (though the progress/seek bar shows the correct length of the video)
  • the same logcat error occurs
  • ExoPlayer times out and forces closed
• the only difference between the two (that I can think of and need to look into) is that the real app calls:
  • playWhenReady(false)
  • does some stuff in another thread
  • after that finished, calls playWhenReady(true)
  • maybe the RTSP library doesn't like that?.. TBD