Allows more errors in the fingerprint API

[kaczmarczyck]

Nothing changes for us, but an actual implementation might need to forward errors when initializing or completing fingerprint checks.

[gemini-code-assist]

Summary of Changes

Hello @kaczmarczyck, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the fingerprint API to allow check_fingerprint_init and check_fingerprint_complete methods to return errors. This change makes the API more flexible for future implementations that might need to propagate errors during fingerprint initialization or completion.

Highlights

• API Signature Change: The check_fingerprint_init method in the Fingerprint trait now returns a CtapResult<()>, enabling error propagation.
• API Signature Change: Similarly, the check_fingerprint_complete method in the Fingerprint trait has been updated to return CtapResult<()>.
• Error Propagation: Existing calls to these methods in perform_built_in_uv have been updated to correctly handle and propagate potential errors using the ? operator.
• Implementation Updates: The implementations of these methods in the test environment (TestFingerprint) and the Tock OS environment have been adjusted to conform to the new return types, returning Ok(()) as they don't currently produce errors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the Fingerprint trait to allow error propagation from check_fingerprint_init and check_fingerprint_complete. The implementations and call sites are updated accordingly. I have one suggestion to make the error handling in perform_built_in_uv more explicit and robust.

[coveralls]

coverage: 97.15%. remained the same
when pulling 8c16d9b on kaczmarczyck:more-errors
into d3bde3e on google:develop.