Skip to content

Conversation

@copybara-service
Copy link

@copybara-service copybara-service bot commented Jan 19, 2026

feat: HITL - Revert the "Boolean confirmation" changes, we'll fix it differently

@r4inee
Copy link
Contributor

r4inee commented Jan 19, 2026

Hey @krwc @mazas-google, it seems like the change is gettin rolled back, did this break some things? keen to learn a bit here.

@krwc
Copy link

krwc commented Jan 21, 2026

Hey @krwc @mazas-google, it seems like the change is gettin rolled back, did this break some things? keen to learn a bit here.

Hi, yeah, we've realized the problem stems from some other underlying issue and we hope to resolve it soon. We'll merge the rollback once we have the proper fix lined up.

@copybara-service copybara-service bot changed the title feat: HITL - reverting "Boolean confirmation" changes, we'll fix it differently feat: HITL - Revert the "Boolean confirmation" changes, we'll fix it differently Jan 21, 2026
@copybara-service copybara-service bot merged commit f65e58b into main Jan 21, 2026
@copybara-service copybara-service bot deleted the test_858276347 branch January 21, 2026 19:23
@krwc
Copy link

krwc commented Jan 22, 2026

Hi @r4inee, would you mind testing against HEAD? We've merged #755 and #757, which should help with your problem as well.

@r4inee
Copy link
Contributor

r4inee commented Jan 22, 2026

Hey @krwc, thanks for the quick turn around - using HEAD, the problem #670 was trying to fix is resolved, after a tool is confirmed and executed, the FC and FR is correctly provided to the subsequent LLM calls, and intermediate events are correctly removed.

However, the problem in #682 still exists where the agent loop is unable to resume if a user provides a follow up prompt after a tool confirmation flow. I'll do a bit more exploring tomorrow to see if I need to amend that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants