fix: Support pipe operator (X | Y) union syntax in function parameter parser #4405
+124
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
types.UnionType(created by Python 3.10+ pipe syntax likelist[str] | None), onlytyping.Union. This caused aValueErrorand fallback to Pydantic, which didn't always work (e.g., in the web builder).types.UnionTypechecks in three conditions within_parse_schema_from_parameter()in_function_parameter_parse_util.py:get_origincheck)isinstanceguard for the GenericAlias blocktyping.Unionregression)Test plan
test_build_function_declaration.pypasspyinkandisortformatting verified viaautoformat.shpyink --checkreports no changes needed)main