fix(auth): remove unneeded OAuth flows#5353
Open
patrasap0908 wants to merge 3 commits intogoogle:mainfrom
Open
fix(auth): remove unneeded OAuth flows#5353patrasap0908 wants to merge 3 commits intogoogle:mainfrom
patrasap0908 wants to merge 3 commits intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Problem
During agent invocation, OAuth redirection happens for every toolset (that returns an
AuthConfig) regardless of whether the user message requires tool invocation or not.Solution
This PR defers the OAuth flow to tool invocation time, which already works as expected.
Testing plan
Unit tests
End-to-end test results:
Checklist
Additional context
Since
_resolve_toolset_auth()will simply defer auth flows to tool invocation time, there is no need to handle the topic of framework- and tool-level credential file path mismatch in this PR. Once consensus is reached, a separate PR can be opened for it later.