Skip to content

fix(auth): remove unneeded OAuth flows#5353

Open
patrasap0908 wants to merge 3 commits intogoogle:mainfrom
patrasap0908:remove-unneeded-oauth-flows
Open

fix(auth): remove unneeded OAuth flows#5353
patrasap0908 wants to merge 3 commits intogoogle:mainfrom
patrasap0908:remove-unneeded-oauth-flows

Conversation

@patrasap0908
Copy link
Copy Markdown

Related issue

Problem

During agent invocation, OAuth redirection happens for every toolset (that returns an AuthConfig) regardless of whether the user message requires tool invocation or not.

Solution

This PR defers the OAuth flow to tool invocation time, which already works as expected.

Testing plan

Unit tests

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

End-to-end test results:

============================================================= 5457 passed, 1 skipped, 2231 warnings in 292.50s (0:04:52) ==============================================================

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Since _resolve_toolset_auth() will simply defer auth flows to tool invocation time, there is no need to handle the topic of framework- and tool-level credential file path mismatch in this PR. Once consensus is reached, a separate PR can be opened for it later.

@adk-bot adk-bot added the core [Component] This issue is related to the core interface and implementation label Apr 16, 2026
@patrasap0908 patrasap0908 changed the title fix (auth): remove unneeded oauth flows fix(auth): remove unneeded OAuth flows Apr 16, 2026
@rohityan rohityan self-assigned this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core [Component] This issue is related to the core interface and implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants