feat: support BigQuery logging and app build type in Agent Builder#398
Open
Genesis929 wants to merge 1 commit intogoogle:mainfrom
Open
feat: support BigQuery logging and app build type in Agent Builder#398Genesis929 wants to merge 1 commit intogoogle:mainfrom
Genesis929 wants to merge 1 commit intogoogle:mainfrom
Conversation
Genesis929
commented
Feb 26, 2026
Genesis929
commented
- Add "Build Type" selection (Agent vs App) when creating new apps.
- Implement BigQuery telemetry configuration (Project ID, Dataset, Table) for App builds.
- Automatically generate agent.py, .env, and init.py for App-type projects.
- Adjust YAML configuration paths and storage structure to support the new build modes.
- Add "Build Type" selection (Agent vs App) when creating new apps. - Implement BigQuery telemetry configuration (Project ID, Dataset, Table) for App builds. - Automatically generate agent.py, .env, and __init__.py for App-type projects. - Adjust YAML configuration paths and storage structure to support the new build modes.
wyf7107
reviewed
Feb 27, 2026
Collaborator
There was a problem hiding this comment.
is this file committed by accident?
| } | ||
|
|
||
| getAgentBuilderTmp(agentName: string) { | ||
| getAgentBuilderTmp(agentName: string, filePath?: string) { |
Collaborator
There was a problem hiding this comment.
why do we need filePath param here? I am concerned because of security issues, if user passes in something like "../../../../my_api_key" that will expose a security risk
|
|
||
| const folderName = `${appName}/${fileName}`; | ||
| // In 'app' mode, YAMLs go into agent_config/ subfolder | ||
| const folderName = isApp ? `${appName}/agent_config/${fileName}` : `${appName}/${fileName}`; |
Collaborator
There was a problem hiding this comment.
so if user creates an app, then the file structure will be app/agent_config/root_agent.yaml but if user already in an app then we don't create the agent_config folder? Is there a discrepancy here?
Orignally, when user creates an agent from visual builder, we create the app folder for them and then the root_agent.yaml inside that app folder, why do we need to specify a type (app/agent) here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.