Skip to content

Minor compatibility fixes for google3-import. #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TristonianJones merged 1 commit into from
Jul 18, 2025
Merged

Minor compatibility fixes for google3-import. #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cel/folding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func MaxConstantFoldIterations(limit int) ConstantFoldingOption {
}
}

// Adds an Activation which provides known values for the folding evaluator
// FoldKnownValues adds an Activation which provides known values for the folding evaluator
//
// Any values the activation provides will be used by the constant folder and turned into
// literals in the AST.
Expand Down
4 changes: 3 additions & 1 deletion cel/folding_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,9 @@ func TestConstantFoldingOptimizer(t *testing.T) {
EnableMacroCallTracking(),
Types(&proto3pb.TestAllTypes{}),
Variable("x", DynType),
Constant("c", IntType, types.Int(proto3pb.ImportedGlobalEnum_IMPORT_BAZ)),
// work around different package convention in piper vs github.
// google.expr.proto3.test.ImportedGlobalEnum.IMPORT_BAZ
Constant("c", IntType, types.Int(2)),
)
if err != nil {
t.Fatalf("NewEnv() failed: %v", err)
Expand Down