Preserve source information during CEL policy composition.#1253
Merged
TristonianJones merged 2 commits intogoogle:masterfrom Jan 29, 2026
Merged
Preserve source information during CEL policy composition.#1253TristonianJones merged 2 commits intogoogle:masterfrom
TristonianJones merged 2 commits intogoogle:masterfrom
Conversation
Collaborator
|
/gcbrun |
abenea
force-pushed
the
sourceinfo
branch
5 times, most recently
from
2d1165f to
720efc8
Compare
The old implementation outputs the wrong source information for policy files derived from the dummy AST created by RuleComposer.Compose. This change fixes that by preserving the correct source and merging the offset ranges of the rule match expressions inserted by the composer optimizer into the final AST.
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Jan 26, 2026
Collaborator
TristonianJones
left a comment
TristonianJones
left a comment
There was a problem hiding this comment.
In general, looks good to me, just one question related to offset computations as it could lead to surprising results in change-detector tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old implementation outputs the wrong source information for policy files derived from the dummy AST created by RuleComposer.Compose. This change fixes that by preserving the correct source and merging the offset ranges of the rule match expressions inserted by the composer optimizer into the final AST.