Handle svg hero images in blocks/cover shortcode#1505
Merged
chalin merged 2 commits intogoogle:mainfrom Feb 2, 2024
Merged
Conversation
chalin
force-pushed
the
block/cover-svg
branch
from
cda21e8 to
c07f47c
Compare
chalin
approved these changes
Feb 2, 2024
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Whitespace clean up, otherwise LGTM
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Contributor
Author
|
Thanks for the review, @chalin ! |
chalin
approved these changes
Feb 2, 2024
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Thanks for the PR @fekete-robert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.