Skip to content

infrastructure: add issue templates#1824

Merged
chalin merged 1 commit intogoogle:mainfrom
deining:issue-templates
Feb 4, 2024
Merged

infrastructure: add issue templates#1824
chalin merged 1 commit intogoogle:mainfrom
deining:issue-templates

Conversation

@deining
Copy link
Copy Markdown
Contributor

@deining deining commented Feb 3, 2024

This PR is a follow-up on the discussion we had in #1632.
It adds issue templates with the hope that most requests come in as discussions and not as issues any more.
This PR is closely related to this discussion post.

@deining deining force-pushed the issue-templates branch 2 times, most recently from 8fd5dc8 to a6d6f39 Compare February 3, 2024 11:07
Copy link
Copy Markdown
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for initiating this @deining. My initial feedback is included inline.

Comment thread .github/ISSUE_TEMPLATE/bug_report.md Outdated
Comment thread .github/ISSUE_TEMPLATE/bug_report.md Outdated
Comment thread .github/ISSUE_TEMPLATE/config.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/config.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/bug_report.md Outdated
Comment thread .github/ISSUE_TEMPLATE/feature_request.md Outdated
Comment thread .github/ISSUE_TEMPLATE/feature_request.md
@deining deining force-pushed the issue-templates branch 3 times, most recently from 3ab9b80 to 8009fb7 Compare February 3, 2024 13:19
@deining
Copy link
Copy Markdown
Contributor Author

deining commented Feb 3, 2024

Thanks for your immediate review, all raised issues are resolved now.

@deining deining requested a review from chalin February 3, 2024 13:20
Copy link
Copy Markdown
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One last suggestion, see inline.

Comment thread .github/ISSUE_TEMPLATE/bug.md Outdated
@deining deining force-pushed the issue-templates branch 2 times, most recently from 9415d2a to 6451a44 Compare February 3, 2024 23:24
@deining
Copy link
Copy Markdown
Contributor Author

deining commented Feb 3, 2024

Added suggestion, rebased PR and fixed formatting issues. Looking forward seeing this merged.

@deining deining requested a review from chalin February 3, 2024 23:28
Copy link
Copy Markdown
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's give this a spin ✨

@chalin chalin merged commit bff41bb into google:main Feb 4, 2024
@deining deining deleted the issue-templates branch February 4, 2024 09:26
@chalin chalin added this to the 24Q1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants