[BS5.3] Replace .navbar-dark by data attribute and other style adjustments#1896
Merged
chalin merged 1 commit intogoogle:mainfrom Mar 26, 2024
Merged
Conversation
.navbar-dark by data attribute
af911fb to
680cca8
Compare
.navbar-dark by data attribute.navbar-dark by data attribute and other style adjustments
680cca8 to
cdd40f4
Compare
Contributor
|
When using a dark system theme under firefox the text in the navbar search is dark (tested on mac and linux): Using Brave (a chrome derivative) it's fine on both systems. But this is probably an edge case, since firefox has a marginal market share, so we can consider it a known issue and go forward. |
fekete-robert
approved these changes
Mar 16, 2024
Collaborator
Author
|
Thanks for that careful cross-browser check. Let's track that issue via: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

.navbar-darkbydata-bs-theme="dark"data attributePreview: https://deploy-preview-1896--docsydocs.netlify.app/docs/
Screenshots
Light mode (default):
Dark mode: