Skip to content

[Dark-mode] Use default BS nav-item padding#1919

Merged
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-dark-mode-menu-style-fix-2024-04-06
Apr 6, 2024
Merged

[Dark-mode] Use default BS nav-item padding#1919
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-dark-mode-menu-style-fix-2024-04-06

Conversation

@chalin
Copy link
Copy Markdown
Collaborator

@chalin chalin commented Apr 6, 2024

  • Contributes to Support dark mode #331
  • Drops the BS dropdown button padding styles px-0 px-lg-2 py-2, in favor of the default BS nav-link padding

Preview: https://deploy-preview-1919--docsydocs.netlify.app/docs/

Screenshots

Before:

image

After:

image

@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
@chalin
Copy link
Copy Markdown
Collaborator Author

chalin commented Apr 6, 2024

Merging. Feedback is still welcome.

@chalin chalin merged commit dd77c40 into google:main Apr 6, 2024
@chalin chalin deleted the chalin-im-dark-mode-menu-style-fix-2024-04-06 branch April 6, 2024 22:33
@chalin chalin mentioned this pull request Apr 6, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant