Skip to content

[Dark-mode] Card shortcode style fixes#1922

Merged
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-dark-mode-card-fixes-2024-04-06
Apr 7, 2024
Merged

[Dark-mode] Card shortcode style fixes#1922
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-dark-mode-card-fixes-2024-04-06

Conversation

@chalin
Copy link
Copy Markdown
Collaborator

@chalin chalin commented Apr 6, 2024

  • Contributes to Support dark mode #331
  • Adjusts card background styles so as to be compatible with light & dark modes

Preview: https://deploy-preview-1922--docsydocs.netlify.app/docs/adding-content/shortcodes/#shortcode-card-programming-code

Screenshots

Only dark-mode is shown below. The before and after are the same in light mode.

Before (dark mode)

image

After (dark mode)

image

@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
@chalin chalin requested a review from deining April 6, 2024 23:36
@chalin chalin mentioned this pull request Apr 6, 2024
26 tasks
Copy link
Copy Markdown
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit 4baa6ed into google:main Apr 7, 2024
@chalin chalin deleted the chalin-im-dark-mode-card-fixes-2024-04-06 branch April 7, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants