Skip to content

copyright.html: process .Site.Copyright as HTML#1954

Merged
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-site-copyright-revert-to-html-processing-2024-04-29
Apr 30, 2024
Merged

copyright.html: process .Site.Copyright as HTML#1954
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-site-copyright-revert-to-html-processing-2024-04-29

Conversation

@chalin
Copy link
Copy Markdown
Collaborator

@chalin chalin commented Apr 29, 2024

  • Fixes Assume .Site.Copyright is HTML for backwards compatibility #1953
  • Tested with @yann-soubeyrand's:
    copyright: |
      Copyright Camptocamp SA
      <p xmlns:cc="http://creativecommons.org/ns#" xmlns:dct="http://purl.org/dc/terms/"><span property="dct:title">Content</span> is licensed under <a href="http://creativecommons.org/licenses/by-sa/4.0/?ref=chooser-v1" target="_blank" rel="license noopener noreferrer" style="display:inline-block;">CC BY-SA 4.0<img style="height:22px!important;margin-left:3px;vertical-align:text-bottom;" src="https://mirrors.creativecommons.org/presskit/icons/cc.svg?ref=chooser-v1"><img style="height:22px!important;margin-left:3px;vertical-align:text-bottom;" src="https://mirrors.creativecommons.org/presskit/icons/by.svg?ref=chooser-v1"><img style="height:22px!important;margin-left:3px;vertical-align:text-bottom;" src="https://mirrors.creativecommons.org/presskit/icons/sa.svg?ref=chooser-v1"></a></p>
    Yielding:
    image
  • Preview: https://deploy-preview-1954--docsydocs.netlify.app/community/

@chalin chalin added this to the 24Q2 milestone Apr 29, 2024
Copy link
Copy Markdown
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin
Copy link
Copy Markdown
Collaborator Author

chalin commented Apr 30, 2024

Thanks for the review @deining. I'm going to merge now. @yann-soubeyrand - your feedback is still welcome.

@chalin chalin merged commit f8a7a1f into google:main Apr 30, 2024
@chalin chalin deleted the chalin-im-site-copyright-revert-to-html-processing-2024-04-29 branch April 30, 2024 06:51
@yann-soubeyrand
Copy link
Copy Markdown
Contributor

Hi @chalin, thanks for the follow-up. It seems OK to me too. As I said, I found a way to pass raw HTML using AsciiDoc, but I didn’t research if there was a way to do the same for Markdown. So, reverting to raw HTML here will ensure it works for both cases.

fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assume .Site.Copyright is HTML for backwards compatibility

3 participants