Refactor navbar and layout SCSS, update examples#2489
Merged
chalin merged 1 commit intogoogle:mainfrom Jan 29, 2026
Merged
Conversation
- Contributes to [google#1655] by restoring some Bootstrap default styles, and moving some extra (navbar)styling to `assets/scss/td/_extra.scss`. Allowing projects to opt-in to the extra styling. - Blog RSS button is not a `btn-primary` (was secondary) - Breaking change for td-boxes (which includes `blocks/*` shortcodes): the value of `min-height` argument is used to set the height of the hero image, when provided. The `auto` setting had no effect on `min-height`. This parameter value has been renamed to `auto-from-top`. The `auto` setting still has no effect on `min-height`, but top margin and top padding are adjusted so that the hero image is framed from the base of the navbar. - `assets/scss/td/_color-adjustments-dark.scss`: among other changes, the scope of SCSS variables has been fixed -- they used to be inside of an `@if $enable-dark-mode` block, and so could not be used. - Navbar styling has been improved: among other changes, the height and background color are now more easily customizable. - Breaking change: Docsy has reverted to the default Bootstrap SCSS variable values (false) for `$enable-gradients` and `$enable-shadows`. - Cleaned up and consolidated `assets/scss/_navbar.scss`, the docsy.dev site's navbar style adjustments. - Added mention of the Goldydocs repository's branch model, etc.
chalin
force-pushed
the
chalin-m24-navbar-2026-0128
branch
from
bce58c6 to
f1e96b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assets/scss/td/_extra.scss. Allowing projects to opt-in to the extra styling.btn-primary(was secondary)blocks/*shortcodes): the value ofmin-heightargument is used to set the height of the hero image, when provided. Theautosetting had no effect onmin-height. This parameter value has been renamed toauto-from-top. Theautosetting still has no effect onmin-height, but top margin and top padding are adjusted so that the hero image is framed from the base of the navbar.assets/scss/td/_color-adjustments-dark.scss: among other changes, the scope of SCSS variables has been fixed -- they used to be inside of an@if $enable-dark-modeblock, and so could not be used.$enable-gradientsand$enable-shadows.assets/scss/_navbar.scss, the docsy.dev site's navbar style adjustments.Preview: https://deploy-preview-2489--docsydocs.netlify.app/