Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| }， | ||
| { | ||
| name: 'Pearsonr', | ||
| description: 'Pearsonr between the monthly C-band and corrected Ku-band signals in the overlapping years.', |
There was a problem hiding this comment.
please change "Pearsonr" to "Pearson correlation coefficient" in the description for clarity
| @@ -0,0 +1,27 @@ | |||
| var visParams_signals = { | |||
There was a problem hiding this comment.
please suggest a preview script generating a thumbnail as well
| var signals_withdate = LHScat.filterDate(start_date,end_date); | ||
| var RMSE = ee.Image("projects/ee-pkurelab/assets/LHScat_v1/RMSE"); | ||
| var Pearsonr = ee.Image("projects/ee-pkurelab/assets/LHScat_v1/Pearsonr"); | ||
| Map.addLayer(signals_withdate,visParams_signals); |
There was a problem hiding this comment.
please add a name for each layer
| ], | ||
| extent: ee.extent_global('1992-04-01T00:00:00Z', '2021-10-01T00:00:00Z'), | ||
| summaries: { | ||
| 'gee:schema': [ |
There was a problem hiding this comment.
I see you have ingested three different datasets:
the collection at projects/ee-pkurelab/assets/LHScat_v1 and the two images projects/ee-pkurelab/assets/LHScat_v1/RMSE and projects/ee-pkurelab/assets/LHScat_v1/Pearsonr
I'll comment in email on a better structure.
| Tao, S., Chave, J., Frison, P.-L., Le Toan, T., Ciais, P., Fang, J., Wigneron, J.-P., Santoro, M., Yang, H., Li, X., Labrière, N., and Saatchi, S.: Increasing and widespread vulnerability of intact tropical rainforests to repeated droughts, Proc. Natl. Acad. Sci. USA, 119, e2116626119, https://doi.org/10.1073/pnas.2116626119, 2022.' | ||
|
|
||
| 'gee:terms_of_use': ee.gee_terms_of_use(license) + '\n\n' + ||| | ||
| The LHScat dataset is publicly released by the PKURE Lab at Peking University for non-commercial use. |
There was a problem hiding this comment.
If the usage is restricted to be only non-commercial, you cannot use spdx.cc0_1_0, which is a public domain license with no restrictions. You probably want CC-BY-NC. Example: https://github.com/google/earthengine-catalog/blob/main/catalog/malariaatlasproject/projects_malariaatlasproject_assets_EVI_v061_1km_8-Daily.jsonnet#L9
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "id": "ee-pkurelab", | |||
There was a problem hiding this comment.
Could you please send us catalog and logo images with the same dimensions as the ones you see in https://developers.google.com/earth-engine/datasets/publisher (catalog images) and https://developers.google.com/earth-engine/datasets/publisher/forestdatapartnership (logo image in the upper right) ?
3 participants
The LHScat dataset is the first long-term (since 1992), high-resolution (∼8.9 km) monthly satellite radar backscatter dataset over global land areas. Our team (PKURELab) has already been in contact with the official Google team. Based on the reference documentation, we have uploaded the relevant code for your review.