Update UMT_Climate_IrrMapper_RF_v1_2.jsonnet#1605
Open
dgketchum wants to merge 1 commit intogoogle:mainfrom
Open
Update UMT_Climate_IrrMapper_RF_v1_2.jsonnet#1605dgketchum wants to merge 1 commit intogoogle:mainfrom
dgketchum wants to merge 1 commit intogoogle:mainfrom
Conversation
Update end date of IrrMapper to cover new 2025 dataset.
simonff
reviewed
Dec 20, 2025
| ee.host_provider(version_config.ee_catalog_url), | ||
| ], | ||
| extent: ee.extent(-124.5, 31.3, -99.0, 49.0, '1986-01-01T00:00:00Z', null), | ||
| extent: ee.extent(-124.5, 31.3, -99.0, 49.0, '1986-01-01T00:00:00Z', '2026-01-01T00:00:00Z'), |
Collaborator
There was a problem hiding this comment.
David, the null end date means the date will be taken from system:start_time of the latest asset. Currently (https://developers.google.com/earth-engine/datasets/catalog/UMT_Climate_IrrMapper_RF_v1_2) the end date is 2025-01-01 - is this right?
What might be confusing is whether we treat the end of a time range as inclusive or exclusive (we are somewhat inconsistent about this).
Contributor
Author
|
Hi Simon, thanks for your quick response to the PR. The new IrrMapper is a
status for 2025, and I thought the end date was exclusive, so I put
2026-01-01, as the asset should cover the whole year. I didn't follow this
pattern, I see now, as in setting the image properties, I had
"'system:time_end': ee.Date('{}-12-31'.format(yr)).millis()". Cheers, David
…On Sat, Dec 20, 2025 at 11:00 AM Simon Ilyushchenko < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In catalog/UMT/UMT_Climate_IrrMapper_RF_v1_2.jsonnet
<#1605 (comment)>
:
> @@ -59,7 +59,7 @@ local version = version_config.version;
ee.producer_provider('University of Montana / Montana Climate Office', 'https://climate.umt.edu/research/irrmapper/'),
ee.host_provider(version_config.ee_catalog_url),
],
- extent: ee.extent(-124.5, 31.3, -99.0, 49.0, '1986-01-01T00:00:00Z', null),
+ extent: ee.extent(-124.5, 31.3, -99.0, 49.0, '1986-01-01T00:00:00Z', '2026-01-01T00:00:00Z'),
David, the null end date means the date will be taken from
system:start_time of the latest asset. Currently (
https://developers.google.com/earth-engine/datasets/catalog/UMT_Climate_IrrMapper_RF_v1_2)
the end date is 2025-01-01 - is this right?
What might be confusing is whether we treat the end of a time range as
inclusive or exclusive (we are somewhat inconsistent about this).
—
Reply to this email directly, view it on GitHub
<#1605 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4DUMXRMKW6A6UTOAXMEYT4CWFFNAVCNFSM6AAAAACPSIDVL6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMBRGIYTAMJSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
David
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update end date of IrrMapper to cover new 2025 dataset.