Improve Maven plugin configuration#2775
Merged
Merged
Conversation
- Explicitly specifies `org.apache.maven.plugins` group ID - Removes redundant `maven-failsafe-plugin` version in `test-shrinker` module This is inherited from the parent POM - Adds required Error Prone compiler arg, see https://github.com/google/error-prone/releases/tag/v2.34.0
eamonnmcmanus
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consists of multiple small changes, but maybe not worth it having separate pull requests for this:
org.apache.maven.pluginsgroup ID, instead of relying on it being used implicitlymaven-failsafe-pluginversion intest-shrinkermodule; this is inherited from thegson-parentPOMIt looks like Error Prone was supposed to enforce usage of
--should-stop=ifError=FLOWin the latest version, but for usage with Maven this check was not performed, see Check that--should-stop=ifError=FLOWis set when EP is set up using the-Xpluginintegration error-prone#4644. So would probably cause a build failure for the next version.