Update J2ObjC Protocol Buffer builder method arguments to default to nonnull.
#2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_642600828
branch
from
08abfc0 to
0c71397
Compare
copybara-service
bot
changed the title
nonnull.
copybara-service
bot
force-pushed
the
test_642600828
branch
3 times, most recently
from
a73185d to
99b4483
Compare
copybara-service
bot
changed the title
nonnull. nonnull.
copybara-service
bot
force-pushed
the
test_642600828
branch
2 times, most recently
from
a5159e0 to
7656925
Compare
…`nonnull`. Java's Protocol Buffer builder implementation does not allow nullable method parameters. This change updates the J2ObjC implementation to match that behavior. Before this change, if a nil pointer was passed in as an argument to a builder method, the application would crash due to a `NullPointerException`. These nullability annotations add an additional safeguard to ensure Swift optionals are properly unwrapped and Objective-C call-sites [properly guard](https://clang.llvm.org/docs/DiagnosticsReference.html#wnonnull) nil values. PiperOrigin-RevId: 644525720
copybara-service
bot
force-pushed
the
test_642600828
branch
from
7656925 to
bcfbe19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update J2ObjC Protocol Buffer builder method arguments to default to
nonnull.Java's Protocol Buffer builder implementation does not allow nullable method parameters. This change updates the J2ObjC implementation to match that behavior. Before this change, if a nil pointer was passed in as an argument to a builder method, the application would crash due to a
NullPointerException.These nullability annotations add an additional safeguard to ensure Swift optionals are properly unwrapped and Objective-C call-sites properly guard nil values.