Enable editions support in j2objc plugin. #2365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_651572153
branch
2 times, most recently
from
c7dc2ed to
d4360e2
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_651572153
branch
3 times, most recently
from
9beb81e to
008f4b7
Compare
Since this is implemented using the C++ runtime, no significant changes were required. This was validated in three ways: 1) Manual audit of the plugin, runtime, and generated code 2) Codegen tests that verify all known edge cases produce identical gencode before and after a migration to edition 2023 3) Migration of all j2objc test protos to edition 2023 passes existing tests Since j2objc mirrors java-lite, all of the relevant feature information is embedded into the gencode using a custom format. Therefore, the runtime doesn't need to worry about feature resolution for reflection. PiperOrigin-RevId: 652680827
copybara-service
bot
force-pushed
the
test_651572153
branch
from
008f4b7 to
058e7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable editions support in j2objc plugin.
Since this is implemented using the C++ runtime, no significant changes were required. This was validated in three ways:
Since j2objc mirrors java-lite, all of the relevant feature information is embedded into the gencode using a custom format. Therefore, the runtime doesn't need to worry about feature resolution for reflection.