Feature Request: Get and Set texture transform info

[fbenedetti06]

Following your kindly upgrade #3263

I am more than interested to be able to change location, scale, rotation of a texture by program!

Without this ability I will be forced to create several 3D model (each one with different texture parameters) and load one depending of texture required... For sure It's not a satisfying way to do it.!

[elalish]

Would you like to submit a PR? Shouldn't be too hard. It's not a high priority at the moment.

[fbenedetti06]

I'm not afraid about coding but to be honest I'm not very used to PR and Github way to do it.
BTW I'm ready to try... I'll have a look to a tutorial about that...

[MrSounds]

@elalish Would it be realistic seeing this feature any time soon?:) I believe scaling textures on a model would be very useful, in for example having a "logo-area" where you could scale the texture (logo) up and down. Probably lots of other use-cases as well.

[elalish]

I'm taking vacation on and off through the holidays, so I don't have time to dedicate to this, but a PR is always welcome! I do think it would be a useful feature. However, what about your use case requires a JS API for this? You can always author your glTF this way, and even author variants with different texture settings you can switch between.

[portedison]

This would be useful - we need to edit Texture.repeat when switching Textures.

Possibly a callback after creating a texture?
https://github.com/google/model-viewer/blob/master/packages/model-viewer/src/features/scene-graph.ts#L131

Are there any hacks in the mean time? Or can I access texture from the return? I see it wrapS / wrapT are in 'sampler'. Not sure how to utilise that.

[elalish]

I believe you can already change the repeat values using e.g. mv.model.materials[0].pbrMetallicRoughness.baseColorTexture.texture.sampler.setWrapS(RepeatWrap); That might only work if you're using our TS, so you might have to manually replace RepeatWrap with 10497 a la the glTF spec.

[portedison]

Thanks @elalish I'll have a tinker, I understood it to be three parts, wrapS wrapT and the repeat. Same as they have here.
https://threejs.org/docs/index.html#api/en/textures/Texture.wrapS

It looks like you only allow the first two?

model-viewer/packages/model-viewer/src/features/scene-graph/sampler.ts

Line 143 in a4639b5

setWrapS(mode: WrapMode) {

[elalish]

Three.js is very closely aligned here with both the WebGL spec and the glTF spec, as they're all designed to be compatible. I believe they even use all the same numerical enum values. We handle all three values: https://github.com/google/model-viewer/blob/master/packages/model-viewer/src/three-components/gltf-instance/gltf-2.0.ts#L104