Support extended AR QuickLook parameters when auto generating USDZ blob#3434
Merged
elalish merged 3 commits intogoogle:masterfrom May 13, 2022
Merged
Support extended AR QuickLook parameters when auto generating USDZ blob#3434elalish merged 3 commits intogoogle:masterfrom
elalish merged 3 commits intogoogle:masterfrom
Conversation
Contributor
Author
|
@elalish - please let me know if you'd like me to tackle in a different way. I couldn't manage to get the unit test working though :( |
elalish
reviewed
May 9, 2022
Contributor
elalish
left a comment
There was a problem hiding this comment.
Thanks! See, that wasn't so bad, was it? 😁
elalish
approved these changes
May 10, 2022
Contributor
elalish
left a comment
There was a problem hiding this comment.
Looks great, thanks! I marked this as ready for review, because I think it's all done now, right?
Contributor
Author
|
Right. I think that's it...! If you're happy, I'm happy. |
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
#3425
Approach
This change allows extended AR QuickLook parameters (EG
custom,checkoutTitle,checkoutSubtitle, etc) to be appended after thesrcpath as#hash fragment when using auto USDZ generation and there is noios-srcproperty.Any / all defined
#params get appended to USDZ blob without discrimination (AR QuickLook will ignore any invalid params).Usage
Define
srcas something like:https://example.com/model.gltf#custom=path-to-banner.htmlOmit
ios-srcInclude
"quick-look"inar-modesto trigger auto USDZ generation.When opening AR on iOS, USDZ will be auto generated and displayed with custom banner in AR.
Tests
Two tests created:
Demo
https://modelviewer-auto-usdz-params.glitch.me/
Compatibility
Note that passing # params after blob url only works in Safari iOS 15.5 beta 4 onwards. Prior to that, passing # params after blob url were either ignored (https://bugs.webkit.org/show_bug.cgi?id=226265) or caused model to never load (https://bugs.webkit.org/show_bug.cgi?id=236069).