Skip to content

Make peer dependency relationship clear in readme#4202

Merged
elalish merged 2 commits intogoogle:masterfrom
johnnyshankman:patch-1
Apr 5, 2023
Merged

Make peer dependency relationship clear in readme#4202
elalish merged 2 commits intogoogle:masterfrom
johnnyshankman:patch-1

Conversation

@johnnyshankman
Copy link
Contributor

@johnnyshankman johnnyshankman commented Apr 5, 2023

Fixes #4197

@google-cla
Copy link

google-cla bot commented Apr 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elalish elalish merged commit ab644f1 into google:master Apr 5, 2023
@johnnyshankman johnnyshankman deleted the patch-1 branch April 6, 2023 19:29
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
* Make peer dependency relationship clear in readme

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README Wrong: When used as an npm module, ThreeJS is a required peer dependency but not marked as so in the readme

2 participants