Skip to content

fixed setting currentTime #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elalish merged 2 commits into from
Apr 19, 2023
Merged

fixed setting currentTime #4231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e8dc43
fixed set time
elalish Apr 19, 2023
e2677a9
revert to initial pose
elalish Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/model-viewer/src/features/animation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ export const AnimationMixin = <T extends Constructor<ModelViewerElementBase>>(

this[$paused] = true;

if (this.animationName != null) {
this[$changeAnimation]();
}

if (this.autoplay) {
this.play();
}
Expand Down
2 changes: 0 additions & 2 deletions packages/model-viewer/src/three-components/ModelScene.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,8 +670,6 @@ export class ModelScene extends Scene {
}
const {animations} = this;
if (animations == null || animations.length === 0) {
console.warn(
`Cannot play animation (model does not have any animations)`);
return;
}

Expand Down