Added postinstall script that updates the three importmap version#4260
Merged
elalish merged 2 commits intogoogle:masterfrom Apr 28, 2023
Merged
Added postinstall script that updates the three importmap version#4260elalish merged 2 commits intogoogle:masterfrom
elalish merged 2 commits intogoogle:masterfrom
Conversation
Merged
elalish
reviewed
Apr 28, 2023
Contributor
|
We're starting to get requests already for post-processing in AR - would you like to take a look at hooking it up in WebXR? I'm hoping it shouldn't take too much. |
Contributor
Author
|
I'll open a separate issue for it with the information I wrote in the original pull request, I'm not sure I'll be able to test it however as I only have access to an Iphone which only experimentally supports WebXR, it would be preferable to test on android. |
Merged
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
…ogle#4260) * Added postinstall script that updates the three importmap version * removed commented code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever npm install is run in
packages/model-viewer,packages/model-viewer-effects/README.mdand the examples inpackages/modelviewer.dev/examples/postprocessing/index.htmlare automatically updated to be in sync with the three version inpackage.json.