Add BoxTextured and sort deployable files.#4310
Merged
diegoteran merged 3 commits intomasterfrom Jun 7, 2023
Merged
Conversation
elalish
suggested changes
Jun 7, 2023
Contributor
There was a problem hiding this comment.
Here's a great example of one where the camera should get changed. Just go to render-fidelity-tools/test/config.json and tweak the corresponding entry.
elalish
reviewed
Jun 7, 2023
Contributor
There was a problem hiding this comment.
@gkjohnson Any thoughts on why the path-tracer vertex colors are so different? I feel like our approximations should be pretty close in this simple case.
Contributor
There was a problem hiding this comment.
Thanks I'll have to take a closer look. I put the pathtracer down for a bit but I'll hopefully be picking it back up soon and I can dive into this.
elalish
approved these changes
Jun 7, 2023
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* Add BoxTextured and sort deployable files. * Update fidelity test images * Update camera-orbit for fidelity images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing deployable file for #4209