Fix API exposing threejs properties#4502
Merged
diegoteran merged 8 commits intomasterfrom Oct 6, 2023
Merged
Conversation
We should not expose threejs from our public api.
elalish
suggested changes
Oct 6, 2023
| Filter.LinearMipmapLinear, | ||
| Filter.NearestMipmapLinear, | ||
| Filter.LinearMipmapLinear | ||
| const minFilterValues: Array<MinificationTextureFilter> = [ |
Contributor
There was a problem hiding this comment.
Can you just use minificationToMinFilter instead of creating this extra list?
| const magFilterValues: Array<MagFilter> = [Filter.Nearest, Filter.Linear]; | ||
| return (value: unknown): value is MagFilter => | ||
| magFilterValues.indexOf(value as MagFilter) > -1; | ||
| const magFilterValues: Array<MagnificationTextureFilter> = |
| @@ -1,5 +1,3 @@ | |||
| import {TextureFilter} from 'three'; | |||
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* Add fix for Wrapping exposed * Add example * Fix sampler updating * Added WrapMode comment * Remove TextureFilter from gltf-2.0 We should not expose threejs from our public api. * clean * Clean and reused maps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes ThreeJS' TextureFilter leak in our API