Added example to toggle between mesh variants#4528
Conversation
elalish
left a comment
elalish
left a comment
There was a problem hiding this comment.
Nice work, the functionality is great! And thanks for including the Glitch link - very helpful for review.
Since this is a public example, code clarity and simplicity are of the utmost importance - I've put in several pointers, but please look through for any ways you can make it simpler and easier to read.
…ing options declerative
elalish
left a comment
elalish
left a comment
There was a problem hiding this comment.
Looks great, just one small update needed.
There was a problem hiding this comment.
I just made exactly this mistake - you need to also add this file to ci-before-deploy.sh or else the public example page won't be able to find it.
There was a problem hiding this comment.
hmm wouldn't this cover it?
shared-assets/models/. \
There was a problem hiding this comment.
Oh shoot, you're right! Thanks.
* Added example to toggle between mesh variants * Fixed the alt * Addressed some of the comments including changing updateAlpha and making options declerative * simplify code and address all comments
2 participants
Reference Issue
link to glitch: