-
Notifications
You must be signed in to change notification settings - Fork 914
Add anisotropy tests to render-fidelity-tests (and update Babylon + Filament to latest) #4535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
70862b6
init submodule for glTF-Sample-Assets.
bhouston 37f5faa
fix left over popd in fetch khronos gltf-smaples.
bhouston e8ead7e
remove tests from config.json that no longer have corresponding asset…
bhouston fb17048
upgrade babylon + filament, check in their latest goldens for new ani…
bhouston 7390b25
update config.json with the new anisotropy tests.
bhouston 17e936e
add more time for tests.
bhouston 33d17e2
add more gltf tests along with goldens for filament,babylon and model…
bhouston b89fa9a
using checkout with submodule support.
bhouston bc5c08f
Merge branch 'additional-tests' of git@github.com:bhouston/model-view…
bhouston 9647901
using checkout with submodule support.
bhouston a11d8cf
update goldens for model-viewer + filament for khronos-TextureTransfo…
bhouston c850c59
update goldens for model-viewer + filament for khronos-TextureTransfo…
bhouston ed9844e
add more goldens for anisotropy from gltf-sample-viewer and three-gpu…
bhouston bce8a03
add more goldens for anisotropy from gltf-sample-viewer and three-gpu…
bhouston 2ed0708
exclude a few renderers for now to get the PR accepted.
bhouston e8e0be2
exclude a few renderers for now to get the PR accepted.
bhouston 66ba502
add gltf-sample viewer goldens for new tests.
bhouston 47167db
add goldens for AnisotropyDiscTest
bhouston 342a9e2
remove barn lamp test for now.
bhouston a8ffc1d
remove blank golden image.
bhouston 26468e2
remove barn lamp test for now.
bhouston b04a230
exclude three-gpu-pathtracer from rotation test.
bhouston 41b8d8d
exclude three-gpu-pathtracer from rotation test.
bhouston 89add3e
Merge remote-tracking branch 'origin/master' into additional-tests
bhouston d6a589b
Merge remote-tracking branch 'origin/master' into additional-tests
bhouston 648c5fc
remove failing test for now.
bhouston 7cd01be
Merge branch 'even-more-tests' into additional-tests
bhouston 6a66cdd
Merge branch 'master' into additional-tests
bhouston 5ee586a
add missing anisotropy goldens, and re-add barn lamp with model-viewe…
bhouston c684bb8
ensure goldens tests are excluded if renderer is excluded.
bhouston 028c52f
remove blank image.
bhouston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+544 KB
...ender-fidelity-tools/test/goldens/khronos-AnisotropyBarnLamp/babylon-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.04 MB
...nder-fidelity-tools/test/goldens/khronos-AnisotropyBarnLamp/filament-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+529 KB
...ity-tools/test/goldens/khronos-AnisotropyBarnLamp/gltf-sample-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+132 KB
...ender-fidelity-tools/test/goldens/khronos-AnisotropyDiscTest/babylon-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+776 KB
...nder-fidelity-tools/test/goldens/khronos-AnisotropyDiscTest/filament-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+52.4 KB
...ity-tools/test/goldens/khronos-AnisotropyDiscTest/gltf-sample-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+121 KB
...-fidelity-tools/test/goldens/khronos-AnisotropyDiscTest/model-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+336 KB
...r-fidelity-tools/test/goldens/khronos-AnisotropyRotationTest/babylon-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.02 MB
...-fidelity-tools/test/goldens/khronos-AnisotropyRotationTest/filament-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+351 KB
...tools/test/goldens/khronos-AnisotropyRotationTest/gltf-sample-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+349 KB
...elity-tools/test/goldens/khronos-AnisotropyRotationTest/model-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+394 KB
...r-fidelity-tools/test/goldens/khronos-AnisotropyStrengthTest/babylon-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.41 MB
...-fidelity-tools/test/goldens/khronos-AnisotropyStrengthTest/filament-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+450 KB
...tools/test/goldens/khronos-AnisotropyStrengthTest/gltf-sample-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+384 KB
...elity-tools/test/goldens/khronos-AnisotropyStrengthTest/model-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+990 KB
...render-fidelity-tools/test/goldens/khronos-ClearCoatCarPaint/babylon-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.36 MB
...ender-fidelity-tools/test/goldens/khronos-ClearCoatCarPaint/filament-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.02 MB
...lity-tools/test/goldens/khronos-ClearCoatCarPaint/gltf-sample-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+979 KB
...r-fidelity-tools/test/goldens/khronos-ClearCoatCarPaint/model-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+213 KB
...delity-tools/test/goldens/khronos-GlassHurricaneCandleHolder/babylon-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+783 KB
...elity-tools/test/goldens/khronos-GlassHurricaneCandleHolder/filament-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+248 KB
...s/test/goldens/khronos-GlassHurricaneCandleHolder/gltf-sample-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+217 KB
...y-tools/test/goldens/khronos-GlassHurricaneCandleHolder/model-viewer-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+351 KB
.../render-fidelity-tools/test/goldens/khronos-GlassVaseFlowers/babylon-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+950 KB
...render-fidelity-tools/test/goldens/khronos-GlassVaseFlowers/filament-golden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+337 KB
...elity-tools/test/goldens/khronos-GlassVaseFlowers/gltf-sample-viewer-golden.png
Oops, something went wrong.
Binary file added
BIN
+325 KB
...er-fidelity-tools/test/goldens/khronos-GlassVaseFlowers/model-viewer-golden.png
Oops, something went wrong.
Binary file added
BIN
+211 KB
...render-fidelity-tools/test/goldens/khronos-NegativeScaleTest/babylon-golden.png
Oops, something went wrong.
Binary file added
BIN
+1.73 MB
...ender-fidelity-tools/test/goldens/khronos-NegativeScaleTest/filament-golden.png
Oops, something went wrong.
Binary file added
BIN
+227 KB
...lity-tools/test/goldens/khronos-NegativeScaleTest/gltf-sample-viewer-golden.png
Oops, something went wrong.
Binary file added
BIN
+206 KB
...r-fidelity-tools/test/goldens/khronos-NegativeScaleTest/model-viewer-golden.png
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did none of the existing renders change appreciably when these versions were bumped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you merge in the other PR, I can run the fidelity test with "filament" as the target renderer and find out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, lots of PRs merged - let's see how this does when it's all pulled together!