Even more tests for render-fidelity test suite#4537
Even more tests for render-fidelity test suite#4537bhouston wants to merge 16 commits intogoogle:masterfrom bhouston:even-more-tests
Conversation
…s in glTF-Sample-Assets
elalish
left a comment
elalish
left a comment
There was a problem hiding this comment.
This looks great, thanks Ben! I'm curious why the CI is having trouble - perhaps the anisotropy renders are extra sensitive to GPU rounding differences? Can you try to render these on a couple of different machines (OS, GPU) and maybe we can figure out what the difference is? I'd love to be able to just get the generated image from the CI, but I've never figured out how to do that.
There was a problem hiding this comment.
Is three-gpu-pathtracer broken? I had heard it may not be keeping up with three.js versions...
|
|
||
| git fetch origin | ||
| git reset --hard origin/master | ||
| git submodule update --init --recursive |
For now I am removing the problematic tests to get the good stuff merged in, and we can revisit the problematic stuff later. |
|
Closing as I've merged this branch into this other related PR: #4535 |
2 participants
In this PR I add the following glTF files to the test suite along with Goldens for filament, Babylon and model-viewer:
This builds upon my other PR here (#4535), so there is additional changes here, but if the other PR is merged then this PR becomes I think a single change.