Conversation
diegoteran
previously approved these changes
Dec 21, 2023
Collaborator
diegoteran
left a comment
diegoteran
left a comment
There was a problem hiding this comment.
Awesome, I'll keep looking into it
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* added GroundedSkybox * updated docs * more docs * added tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three.js ground-projected-skybox example I found did not work well in practice, so I made my own simpler version. This goes along nicely with our new UltraHDR support because now we can transmit high-fidelity HDR lighting environments to use as skyboxes.
As with ground-projected skyboxes generally, it'll only look decent if the image is taken on fairly flat ground without nearby stuff that sticks up. The
skybox-heightattribute is used to get the proper scale of the image on the ground. If you know the height at which the image was taken, simply put that in - otherwise experiment until it looks reasonable. Ideally you'll want a height that is on the same order as the size of the model for it to look good.