Conversation
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* refactor environmentScene * commerce lighting is testable * removed commerce lighting * upgrade commerce tone mapper * added exposure compensation * revert example changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a small contrast "toe" to the function, aligned to compensate for the average Fresnel deesaturation that occurs with PBR for dielectrics with the default IoR of 1.5. This makes it much easier to match glTF base colors to output colors, and fixes the desaturated, low contrast look of commerce as compared to ACES.
The commerce tone mapper has a meaningful exposure: with lighting [1,1,1], you get exactly the base color out (for most of the sRGB range). ACES has no such peg - it happens to be a bit brighter. For our 'neutral' and 'legacy' lighting, I've made an automatic exposure compensation, so that ACES and commerce tone mapping have the same "visual" exposure. If you're using your own lighting environment and want to compare tone mapping, use
exposure='1'for commerce andexposure='0.77'for ACES (or 1.3 and 1).