Upgrade three-gpu-pathtracer, screenshots#4686
Merged
elalish merged 6 commits intogoogle:masterfrom Feb 29, 2024
Merged
Conversation
elalish
approved these changes
Feb 29, 2024
Contributor
elalish
left a comment
There was a problem hiding this comment.
This looks great, thanks! FYI, in the coming weeks I'm going to be migrating this fidelity test suite (include your code) over to Khronos, who have graciously decided to adopt and promote it. Ideally your work will be done before I start, but I'll let you know when I'm beginning in case. Of course we'll all still be contributing just as we were before, just in a different repo (using git LFS finally!).
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* bump versions * Update package lock * Small changes to renderer * Update screenshots * Remove screenshots * Update samples, config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recently gotten three-gpu-pathtracer working consistently again after a slew of browser regressions on a few platforms. So this PR upgrades the three-gpu-pathtracer version to latest and associated screenshots. There have been a number of sampling and geometry handling improvements over those versions, as well.
Some other notes:
Once this is merged I'll make a new PR that enables some other screenshots that for new models that now work and have been added to the config.
cc @bhouston