Skip to content

Upgrade three-gpu-pathtracer, screenshots#4686

Merged
elalish merged 6 commits intogoogle:masterfrom
gkjohnson:pt-upgrade
Feb 29, 2024
Merged

Upgrade three-gpu-pathtracer, screenshots#4686
elalish merged 6 commits intogoogle:masterfrom
gkjohnson:pt-upgrade

Conversation

@gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented Feb 21, 2024

I've recently gotten three-gpu-pathtracer working consistently again after a slew of browser regressions on a few platforms. So this PR upgrades the three-gpu-pathtracer version to latest and associated screenshots. There have been a number of sampling and geometry handling improvements over those versions, as well.

Some other notes:

  • Samples have been lowered from 100 to 64 since puppeteer was timing out and I couldn't figure out how to increase the time. It shouldn't be taking longer than before but it seems the timeout has gotten shorter?
  • Two screenshots have been removed because they don't look correct, likely have some recent material changes in the sample GLB files. I'll need to investigate and can add them back later.
  • Note that some of the simple models are darker because they have a high metalness value which incurs a lot of energy loss with rough surfaces in the pathtracer at the moment which is a common issue, I understand. It's on the list to be looked at.

Once this is merged I'll make a new PR that enables some other screenshots that for new models that now work and have been added to the config.

cc @bhouston

Copy link
Contributor

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! FYI, in the coming weeks I'm going to be migrating this fidelity test suite (include your code) over to Khronos, who have graciously decided to adopt and promote it. Ideally your work will be done before I start, but I'll let you know when I'm beginning in case. Of course we'll all still be contributing just as we were before, just in a different repo (using git LFS finally!).

@elalish elalish merged commit 6c16da3 into google:master Feb 29, 2024
@gkjohnson gkjohnson deleted the pt-upgrade branch March 1, 2024 00:54
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
* bump versions

* Update package lock

* Small changes to renderer

* Update screenshots

* Remove screenshots

* Update samples, config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants