Add explicit file extensions to relative imports of model-viewer and model-viewer-effects#4707
Merged
elalish merged 1 commit intogoogle:masterfrom Mar 11, 2024
Merged
Conversation
…model-viewer-effects
elalish
approved these changes
Mar 11, 2024
Contributor
elalish
left a comment
elalish
left a comment
There was a problem hiding this comment.
Thanks! Not sure why we had our imports half and half - consistency is good!
chamby
added a commit
to chamby/model-viewer
that referenced
this pull request
Mar 12, 2024
…del-viewer-effects (google#4707)
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
…model-viewer-effects (google#4707)
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
…del-viewer-effects (google#4707) (google#4710)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes: #4688