A11y implementation for WCAG compliance.#4715
Merged
elalish merged 4 commits intogoogle:masterfrom Apr 3, 2024
Merged
Conversation
|
Some context for the PR. We have talked about this trough email before. The current implementation has accessibility support; however, it is not localized. We would like to bring some attention to it and work towards making sure it follows the standards required by the EU. |
elalish
reviewed
Mar 14, 2024
elalish
suggested changes
Mar 22, 2024
elalish
approved these changes
Apr 3, 2024
Contributor
elalish
left a comment
elalish
left a comment
There was a problem hiding this comment.
This looks excellent - thank you for the tests!
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* A11y implementation for WCAG compliance. * Readd in controls, merge examples into loading and add docs. * Added a language switch in example page. * Added tests in control for a11y and minor review fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.