parse_hotspot_config.ts DOM text reinterpreted as HTML #4748
Merged
elalish merged 2 commits intogoogle:masterfrom Apr 15, 2024
Merged
parse_hotspot_config.ts DOM text reinterpreted as HTML #4748elalish merged 2 commits intogoogle:masterfrom
elalish merged 2 commits intogoogle:masterfrom
Conversation
elalish
suggested changes
Apr 15, 2024
Contributor
elalish
left a comment
elalish
left a comment
There was a problem hiding this comment.
It looks like TS is complaining because it's not sure if the query you did is returning the right kind of element. Should be a simple casting fix.
Contributor
Author
|
Hi @elalish |
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* Update parse_hotspot_config.ts * Updated parse_hotspot_config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML. Always be cautious when dealing with user input or dynamic content to prevent security risks.