Skip to content

Fixes code example #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elalish merged 2 commits into from
Aug 7, 2024
Merged

Fixes code example #4851

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
380c3b0
Fixed code example
Hamidrzash Aug 7, 2024
713c653
checks model is visible
Hamidrzash Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/modelviewer.dev/examples/scenegraph/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,14 +759,16 @@ <h2 class="demo-title">Materials API</h2>

modelViewer.addEventListener("load", () => {
const changeColor = (event) => {
const material = modelViewer.materialFromPoint(event.clientX, event.clientY);
if (material != null) {
material.pbrMetallicRoughness.
setBaseColorFactor([Math.random(), Math.random(), Math.random()]);
if(modelViewer.modelIsVisible){
const material = modelViewer.materialFromPoint(event.clientX, event.clientY);
if (material != null) {
material.pbrMetallicRoughness.
setBaseColorFactor([Math.random(), Math.random(), Math.random()]);
}
}
};

modelViewer.addEventListener("click", changeColor);
document.addEventListener("click", changeColor);
Copy link
Contributor

@elalish elalish Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this whole page? I'm guessing since there are multiple examples, this might have odd behavior. Maybe add a check in changeColor to ensure the event came through the right element?

Copy link
Contributor Author

@Hamidrzash Hamidrzash Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a check in changeColor to ensure the event came through the right element?

You are right. i think my new commit fixes this

});
</script>
<script>
Expand Down