make PBR Neutral our default tone mapper#4886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's our big breaking change for v4.0. It's only breaking because the rendering look is changing by default, which generally means you need to either update your poster images or set
tone-mapping="aces"to get our previous default look.Thanks for all the warm reception to my talk at SIGGRAPH and from the e-commerce industry generally! Looks like PBR Neutral is indeed what most folks want for our main use cases. Take a look at the image diffs in this PR to see the visual change of ACES -> PBR Neutral.