Skip to content

Set the aces value in the tone-mapping item#4890

Merged
elalish merged 1 commit intogoogle:masterfrom
rsax:rsax-patch-1
Sep 23, 2024
Merged

Set the aces value in the tone-mapping item#4890
elalish merged 1 commit intogoogle:masterfrom
rsax:rsax-patch-1

Conversation

@rsax
Copy link
Contributor

@rsax rsax commented Sep 19, 2024

The “aces” option in the tone mapping selector of the editor is missing a specified value.

@google-cla
Copy link

google-cla bot commented Sep 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! Would you mind signing the CLA? Should be automatic for an individual.

@rsax rsax requested a review from elalish September 22, 2024 07:31
@elalish
Copy link
Contributor

elalish commented Sep 23, 2024

@googlebot I fixed it.

@elalish
Copy link
Contributor

elalish commented Sep 23, 2024

@rsax did you have any trouble signing the CLA? I can't take your code until you do. It's by the email associated with your commit: @rsax <rs*****al​@plasmout.com>.

@rsax
Copy link
Contributor Author

rsax commented Sep 23, 2024

You’re right, I signed with a different email. Please revalidate.

@elalish elalish merged commit 291c9d1 into google:master Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants