Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

update broken links, wrap stdout for python 2 and warning for character-level models#176

Closed
SwordYork wants to merge 3 commits intogoogle:masterfrom
SwordYork:master
Closed

update broken links, wrap stdout for python 2 and warning for character-level models#176
SwordYork wants to merge 3 commits intogoogle:masterfrom
SwordYork:master

Conversation

@SwordYork
Copy link
Copy Markdown

@SwordYork SwordYork commented Apr 19, 2017

Hi, I have provided some fixes.

  1. Update the broken links of NMT and optimize_loss.
  2. Wrap the stdout for python 2. Maybe a more graceful way for PR Fix unicode print error #96.
  3. Add a warning for character-level models. As Handling special characters for character seq2seq model  #153 illustrated, we shouldn't use tf.string_split for unicode strings. However, I could not find any elegant way to deal with it. Maybe we need to implement a new op, for example, tf.decode_unicode(). At least, we should add a warning for this issue.

Thanks.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@SwordYork
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@SwordYork SwordYork closed this Apr 19, 2017
@SwordYork SwordYork reopened this Apr 19, 2017
@SwordYork
Copy link
Copy Markdown
Author

SwordYork commented Apr 19, 2017

I have undo the push to github previously.
I don't why ci/circleci does not start.
I have run unit test under python 2 and python 3 locally, also checked with the pylint.

@SwordYork SwordYork closed this Apr 19, 2017
@SwordYork SwordYork reopened this Apr 19, 2017
@dennybritz
Copy link
Copy Markdown
Contributor

Hm, it's weird that CircleCI doesn't run it. I'll look into it and run it manually. Thanks!

@SwordYork SwordYork closed this Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants