This repository was archived by the owner on Dec 29, 2022. It is now read-only.
update broken links, wrap stdout for python 2 and warning for character-level models#176
Closed
SwordYork wants to merge 3 commits intogoogle:masterfrom
SwordYork:master
Closed
update broken links, wrap stdout for python 2 and warning for character-level models#176SwordYork wants to merge 3 commits intogoogle:masterfrom SwordYork:master
SwordYork wants to merge 3 commits intogoogle:masterfrom
SwordYork:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
Author
|
I have undo the push to github previously. |
Contributor
|
Hm, it's weird that CircleCI doesn't run it. I'll look into it and run it manually. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have provided some fixes.
tf.string_splitfor unicode strings. However, I could not find any elegant way to deal with it. Maybe we need to implement a new op, for example,tf.decode_unicode(). At least, we should add a warning for this issue.Thanks.